Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5045] Add ability to create Google Dataproc cluster with cus… #5752

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

idralyuk
Copy link
Contributor

@idralyuk idralyuk commented Aug 7, 2019

…tom image from a different project

Jira

https://issues.apache.org/jira/browse/AIRFLOW-5045

Description

AIRFLOW-2797 added functionality to create Dataproc clusters with custom images. Unfortunately the images can only be defined in the current project. This PR adds ability to define a custom image project.

For more info see: https://cloud.google.com/dataproc/docs/guides/dataproc-images

Tests

One test added:

it checks whether the custom image project id was set correctly

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@codecov-io
Copy link

Codecov Report

Merging #5752 into master will decrease coverage by 0.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5752      +/-   ##
==========================================
- Coverage   79.93%   79.28%   -0.65%     
==========================================
  Files         498      498              
  Lines       32188    32190       +2     
==========================================
- Hits        25728    25523     -205     
- Misses       6460     6667     +207
Impacted Files Coverage Δ
airflow/contrib/operators/dataproc_operator.py 86.26% <100%> (+0.07%) ⬆️
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_to_hive.py 0% <0%> (-100%) ⬇️
airflow/operators/generic_transfer.py 0% <0%> (-100%) ⬇️
airflow/executors/celery_executor.py 40.74% <0%> (-35.56%) ⬇️
airflow/utils/log/wasb_task_handler.py 32.87% <0%> (-9.59%) ⬇️
airflow/utils/sqlalchemy.py 73.25% <0%> (-5.82%) ⬇️
airflow/utils/log/es_task_handler.py 87.15% <0%> (-4.59%) ⬇️
airflow/hooks/dbapi_hook.py 85.08% <0%> (-3.51%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1da8c...b925684. Read the comment docs.

@potiuk potiuk merged commit cb31d08 into apache:master Aug 8, 2019
kaxil pushed a commit that referenced this pull request Dec 19, 2019
…tom image from a different project (#5752)

(cherry picked from commit cb31d08)
ashb pushed a commit that referenced this pull request Dec 19, 2019
…tom image from a different project (#5752)

(cherry picked from commit cb31d08)
kaxil pushed a commit that referenced this pull request Dec 19, 2019
…tom image from a different project (#5752)

(cherry picked from commit cb31d08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants