-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5143] Fix for potentially corrupted .jar #5759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apache Rat also provides SHA256 checksums for verifying the integrity. WDYT of using those?
b707bb8
to
3fe27e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx for picking this up @potiuk
3fe27e7
to
72c1d6b
Compare
I realised I already moved the licence check to separate Dockerfile - so I fixed it now in the RIGHT place and removed it from the CI Dockerfile as it is not needed there ! |
caffbe0
to
1d23053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @potiuk
1d23053
to
7da1a3d
Compare
One more pass. One of the tests failed and I realised that we've been building checklicence image needlessly in tests. |
(cherry picked from commit 8288cf1)
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8