Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5143] Fix for potentially corrupted .jar #5759

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 8, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk potiuk requested review from kaxil and dimberman August 8, 2019 10:46
Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@BasPH BasPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache Rat also provides SHA256 checksums for verifying the integrity. WDYT of using those?

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for picking this up @potiuk

Dockerfile-checklicence Outdated Show resolved Hide resolved
Dockerfile-checklicence Outdated Show resolved Hide resolved
@potiuk
Copy link
Member Author

potiuk commented Aug 8, 2019

I realised I already moved the licence check to separate Dockerfile - so I fixed it now in the RIGHT place and removed it from the CI Dockerfile as it is not needed there !

@potiuk potiuk requested a review from mik-laj August 8, 2019 12:30
@potiuk potiuk force-pushed the fix-rat-download-problem branch 2 times, most recently from caffbe0 to 1d23053 Compare August 8, 2019 12:36
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @potiuk

@potiuk
Copy link
Member Author

potiuk commented Aug 8, 2019

One more pass. One of the tests failed and I realised that we've been building checklicence image needlessly in tests.

@potiuk potiuk merged commit 8288cf1 into apache:master Aug 8, 2019
potiuk added a commit that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants