Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5153] Option to force delete non-empty BQ datasets #5768

Conversation

mohannadbanayosi
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This extra bool argument gives the option to delete a non-empty Google BigQuery dataset as well as its tables.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mohannadbanayosi mohannadbanayosi force-pushed the AIRFLOW-5153_Force_delete_non_empty_bq_dataset_option branch from 86b8235 to b2674e6 Compare August 9, 2019 13:51
This gives the option to delete the dataset as well as its tables.
@mohannadbanayosi mohannadbanayosi force-pushed the AIRFLOW-5153_Force_delete_non_empty_bq_dataset_option branch from b2674e6 to b6aac95 Compare August 9, 2019 14:29
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Aug 9, 2019
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaxil kaxil merged commit fae5b37 into apache:master Aug 12, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Oct 11, 2019
)

This gives the option to delete the dataset as well as its tables.

(cherry picked from commit fae5b37)
adityav pushed a commit to adityav/airflow that referenced this pull request Oct 14, 2019
)

This gives the option to delete the dataset as well as its tables.

(cherry picked from commit fae5b37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants