Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5169] Pass Project ID explicitly to StorageClient in GCS Hook #5783

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Aug 12, 2019

…Hook

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

If Project_id is not passed to the StorageClient it tries to infer the Project_ID from the environment variables or Cloud SDK.

If neither env variables is set nor Cloud SDK is configured it will error with the following message:

google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started

Tests

  • [] My PR adds the following unit tests OR does not need testing for this extremely good reason:
    I need some help on adding a test to check that project_id exists when storage client is created @mik-laj

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@kaxil kaxil requested a review from mik-laj August 12, 2019 11:25
@kaxil kaxil changed the title [AIRFLOW-5169] Pass GCP Project ID explicitly to StorageClient in GCS… [AIRFLOW-5169] Pass Project ID explicitly to StorageClient in GCS Hook Aug 12, 2019
Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be able to define the project ID using a parameter in the future. Now it looks good to me.

@kaxil kaxil merged commit 1211675 into apache:master Aug 12, 2019
@kaxil kaxil deleted the airflow-5169 branch August 12, 2019 13:59
kaxil added a commit that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants