Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5204] Shellcheck + common licences + executable shebangs in shell files #5807

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 13, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk potiuk force-pushed the shellcheck-shell-files branch 2 times, most recently from 7567788 to 6b28471 Compare August 15, 2019 05:11
@potiuk potiuk changed the title [AIRFLOW-5204] Shellcheck + common licence in shell files (depends on AIRFLOW-5161, AIRFLOW-5170, AIRFLOW-5180) [AIRFLOW-5204] Shellcheck + common licence in shell files Aug 15, 2019
@potiuk potiuk changed the title [AIRFLOW-5204] Shellcheck + common licence in shell files [AIRFLOW-5204] Shellcheck + common licences in shell files Aug 15, 2019
@potiuk
Copy link
Member Author

potiuk commented Aug 15, 2019

Again - another set of checks. This time for shell files (shellcheck + shebangs/executable + licenses)

@potiuk potiuk changed the title [AIRFLOW-5204] Shellcheck + common licences in shell files [AIRFLOW-5204] Shellcheck + common licences + executable shebangs in shell files Aug 15, 2019
@mik-laj mik-laj added the area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code label Aug 16, 2019
Shell files are all now checked via shellcheck and have common licence
@potiuk
Copy link
Member Author

potiuk commented Aug 20, 2019

This one is badly needed I think. Having linted/shellchecked bash scripts in Airflow would be great to have.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@milton0825 milton0825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one small nit.

Co-Authored-By: Chao-Han Tsai <[email protected]>
@potiuk potiuk merged commit 6420712 into apache:master Aug 20, 2019
potiuk added a commit that referenced this pull request Aug 20, 2019
… shell files (#5807)

* [AIRFLOW-5204] Shellcheck + common licence in shell files

(cherry picked from commit 6420712)
@potiuk
Copy link
Member Author

potiuk commented Aug 20, 2019

Thanks! merged.

Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
… shell files (apache#5807)

* [AIRFLOW-5204] Shellcheck + common licence in shell files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants