-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5204] Shellcheck + common licences + executable shebangs in shell files #5807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
shellcheck-shell-files
branch
from
August 13, 2019 15:03
9a1e0f7
to
d5014d2
Compare
ashb
reviewed
Aug 13, 2019
potiuk
force-pushed
the
shellcheck-shell-files
branch
2 times, most recently
from
August 15, 2019 05:11
7567788
to
6b28471
Compare
potiuk
changed the title
[AIRFLOW-5204] Shellcheck + common licence in shell files (depends on AIRFLOW-5161, AIRFLOW-5170, AIRFLOW-5180)
[AIRFLOW-5204] Shellcheck + common licence in shell files
Aug 15, 2019
potiuk
force-pushed
the
shellcheck-shell-files
branch
from
August 15, 2019 05:31
6b28471
to
9e7c514
Compare
potiuk
changed the title
[AIRFLOW-5204] Shellcheck + common licence in shell files
[AIRFLOW-5204] Shellcheck + common licences in shell files
Aug 15, 2019
Again - another set of checks. This time for shell files (shellcheck + shebangs/executable + licenses) |
potiuk
changed the title
[AIRFLOW-5204] Shellcheck + common licences in shell files
[AIRFLOW-5204] Shellcheck + common licences + executable shebangs in shell files
Aug 15, 2019
potiuk
force-pushed
the
shellcheck-shell-files
branch
from
August 16, 2019 02:04
9e7c514
to
3cb1c74
Compare
mik-laj
added
the
area:dev-env
CI, pre-commit, pylint and other changes that do not change the behavior of the final code
label
Aug 16, 2019
Shell files are all now checked via shellcheck and have common licence
potiuk
force-pushed
the
shellcheck-shell-files
branch
from
August 18, 2019 13:35
3cb1c74
to
909509f
Compare
This one is badly needed I think. Having linted/shellchecked bash scripts in Airflow would be great to have. |
milton0825
reviewed
Aug 20, 2019
milton0825
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from one small nit.
Co-Authored-By: Chao-Han Tsai <[email protected]>
potiuk
added a commit
that referenced
this pull request
Aug 20, 2019
… shell files (#5807) * [AIRFLOW-5204] Shellcheck + common licence in shell files (cherry picked from commit 6420712)
Thanks! merged. |
Jerryguo
pushed a commit
to Jerryguo/airflow
that referenced
this pull request
Sep 2, 2019
… shell files (apache#5807) * [AIRFLOW-5204] Shellcheck + common licence in shell files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:dev-env
CI, pre-commit, pylint and other changes that do not change the behavior of the final code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8