-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5205] Check xml files with xmllint + Licenses #5808
Conversation
What's the point of opening this PR? It is impossible to review with some many dependencies on other PRs. |
8cee4b0
to
3fd4e0c
Compare
Agree with Fokko. I personally don't want to be responsible for reviewing such a huge PR and maybe miss something - but I really like reviewing PR's in general :( @potiuk do you think it is possible to split it into smaller ones? |
I've noticed that the PR's in the list are sequential, it starts with this one: #5777 |
@Fokko @feluelle : apologies for that. i split those changes into smaller, fairly independent commits (hence the "depends on" in the PR title). And it was much easier to do the "series" of commits. They all depend on the #5777 and once I merge that one (Thanks @Fokko for the approaval), I will actually change those commits/PR and make them totally separate (and not depending on each other). |
3fd4e0c
to
ef64d0b
Compare
Made the PR standalone (not depending on series of PRs |
ef64d0b
to
3951558
Compare
3951558
to
2aba112
Compare
This one is really small and mostly about consistency in licence. Rather straightforward (the only potential problem is necessity of xmllint - but this is really not a problem because pre-commit will skip that check if you don't modify any of the xml files - so you won't need xmllint in most of the cases. |
2aba112
to
d1831bb
Compare
(cherry picked from commit d8c9bdc)
(cherry picked from commit d8c9bdc)
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8