Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5205] Check xml files with xmllint + Licenses #5808

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 13, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk potiuk requested review from BasPH, mik-laj and Fokko August 13, 2019 15:05
@Fokko
Copy link
Contributor

Fokko commented Aug 13, 2019

What's the point of opening this PR? It is impossible to review with some many dependencies on other PRs.

@feluelle
Copy link
Member

Agree with Fokko. I personally don't want to be responsible for reviewing such a huge PR and maybe miss something - but I really like reviewing PR's in general :(

@potiuk do you think it is possible to split it into smaller ones?

@Fokko
Copy link
Contributor

Fokko commented Aug 13, 2019

I've noticed that the PR's in the list are sequential, it starts with this one: #5777

@potiuk
Copy link
Member Author

potiuk commented Aug 14, 2019

@Fokko @feluelle : apologies for that. i split those changes into smaller, fairly independent commits (hence the "depends on" in the PR title). And it was much easier to do the "series" of commits. They all depend on the #5777 and once I merge that one (Thanks @Fokko for the approaval), I will actually change those commits/PR and make them totally separate (and not depending on each other).

@potiuk potiuk changed the title [AIRFLOW-5205] Check xml files depends on AIRFLOW-5161, AIRFLOW-5170, AIRFLOW-5180, AIRFLOW-5204, [AIRFLOW-5205] Check xml files with xmllint + Licenses Aug 15, 2019
@potiuk
Copy link
Member Author

potiuk commented Aug 15, 2019

Made the PR standalone (not depending on series of PRs

@potiuk potiuk force-pushed the check-xml-files branch 3 times, most recently from ef64d0b to 3951558 Compare August 16, 2019 02:06
@mik-laj mik-laj added the area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code label Aug 16, 2019
@potiuk
Copy link
Member Author

potiuk commented Aug 20, 2019

This one is really small and mostly about consistency in licence. Rather straightforward (the only potential problem is necessity of xmllint - but this is really not a problem because pre-commit will skip that check if you don't modify any of the xml files - so you won't need xmllint in most of the cases.

@potiuk potiuk merged commit d8c9bdc into apache:master Aug 20, 2019
potiuk added a commit that referenced this pull request Aug 20, 2019
potiuk added a commit that referenced this pull request Aug 20, 2019
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants