-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5118] Add ability to specify optional components in Dataproc… #5821
Conversation
…ClusterCreateOperator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ;)
@@ -121,6 +121,9 @@ class DataprocClusterCreateOperator(DataprocOperationBaseOperator): | |||
config files (e.g. spark-defaults.conf), see | |||
https://cloud.google.com/dataproc/docs/reference/rest/v1/projects.regions.clusters#SoftwareConfig | |||
:type properties: dict | |||
:param optional_components: List of optional cluster components, for more info see | |||
https://cloud.google.com/dataproc/docs/reference/rest/v1/ClusterConfig#Component | |||
:type optional_components: list[str] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:type optional_components: list[str] | |
:type optional_components: List[str] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is inconsistency in this file in the way types are written. We have to review all types then we will standarize it. Now the current version is more popular.
…ClusterCreateOperator (apache#5821)
…ClusterCreateOperator
Jira
https://issues.apache.org/jira/browse/AIRFLOW-5118
Description
This PR adds ability to specify optional components in DataprocClusterCreateOperator
For more info see https://cloud.google.com/dataproc/docs/reference/rest/v1/ClusterConfig#Component
Tests
One test added: it checks whether the optional components were set correctly
Commits
Documentation
Code Quality
flake8