Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5118] Add ability to specify optional components in Dataproc… #5821

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

idralyuk
Copy link
Contributor

…ClusterCreateOperator

Jira

https://issues.apache.org/jira/browse/AIRFLOW-5118

Description

This PR adds ability to specify optional components in DataprocClusterCreateOperator

For more info see https://cloud.google.com/dataproc/docs/reference/rest/v1/ClusterConfig#Component

Tests

One test added: it checks whether the optional components were set correctly

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Aug 14, 2019
Copy link
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@@ -121,6 +121,9 @@ class DataprocClusterCreateOperator(DataprocOperationBaseOperator):
config files (e.g. spark-defaults.conf), see
https://cloud.google.com/dataproc/docs/reference/rest/v1/projects.regions.clusters#SoftwareConfig
:type properties: dict
:param optional_components: List of optional cluster components, for more info see
https://cloud.google.com/dataproc/docs/reference/rest/v1/ClusterConfig#Component
:type optional_components: list[str]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:type optional_components: list[str]
:type optional_components: List[str]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is inconsistency in this file in the way types are written. We have to review all types then we will standarize it. Now the current version is more popular.

@mik-laj mik-laj merged commit fd544eb into apache:master Aug 28, 2019
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
kaxil pushed a commit that referenced this pull request Dec 19, 2019
…ClusterCreateOperator (#5821)

(cherry picked from commit fd544eb)
ashb pushed a commit that referenced this pull request Dec 19, 2019
…ClusterCreateOperator (#5821)

(cherry picked from commit fd544eb)
kaxil pushed a commit that referenced this pull request Dec 19, 2019
…ClusterCreateOperator (#5821)

(cherry picked from commit fd544eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants