-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5218] less polling for AWS Batch status #5825
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazza-codes
force-pushed
the
patch-1
branch
2 times, most recently
from
August 15, 2019 04:42
88d032c
to
6f06246
Compare
feluelle
reviewed
Aug 15, 2019
dazza-codes
force-pushed
the
patch-1
branch
2 times, most recently
from
August 15, 2019 18:02
6945fad
to
dd75d37
Compare
Most of the CI builds are OK but one of them timed-out and I don't have access to restart it |
ashb
requested changes
Aug 16, 2019
Review requests addressed
|
https://issues.apache.org/jira/browse/AIRFLOW-5218 - avoid the AWS API throttle limits for highly concurrent tasks - a small increase in the backoff factor could avoid excessive polling - random sleep before polling to allow the batch task to spin-up - the random sleep helps to avoid API throttling - revise the retry logic slightly to avoid unnecessary pause when there are no more retries required
ashb
approved these changes
Aug 19, 2019
Jerryguo
pushed a commit
to Jerryguo/airflow
that referenced
this pull request
Sep 2, 2019
https://issues.apache.org/jira/browse/AIRFLOW-5218 - avoid the AWS API throttle limits for highly concurrent tasks - a small increase in the backoff factor could avoid excessive polling - random sleep before polling to allow the batch task to spin-up - the random sleep helps to avoid API throttling - revise the retry logic slightly to avoid unnecessary pause when there are no more retries required
ashb
pushed a commit
that referenced
this pull request
Oct 11, 2019
https://issues.apache.org/jira/browse/AIRFLOW-5218 - avoid the AWS API throttle limits for highly concurrent tasks - a small increase in the backoff factor could avoid excessive polling - random sleep before polling to allow the batch task to spin-up - the random sleep helps to avoid API throttling - revise the retry logic slightly to avoid unnecessary pause when there are no more retries required (cherry picked from commit fc972fb)
adityav
pushed a commit
to adityav/airflow
that referenced
this pull request
Oct 14, 2019
https://issues.apache.org/jira/browse/AIRFLOW-5218 - avoid the AWS API throttle limits for highly concurrent tasks - a small increase in the backoff factor could avoid excessive polling - random sleep before polling to allow the batch task to spin-up - the random sleep helps to avoid API throttling - revise the retry logic slightly to avoid unnecessary pause when there are no more retries required (cherry picked from commit fc972fb)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Description
See also:
Here are some quotes from that message forum link above (note that the forum comments are dated approx 2017 through to 2019 and improvements are released over time). AWS batch support says,
AWS batch support note that improvements are released over time,
But, when 100's of jobs require a scaling solution, the delays can be longer,
Tests
Commits
Documentation
Code Quality
flake8