[AIRFLOW-5226] Consistent licences for all jinja templates

[potiuk]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-5226

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

• Passes flake8

[potiuk]

Bumping up . It's rather small change but adds too our lineup of static checks

[potiuk]

Should be good to go @ashb :)\

[potiuk]

Ping here.

[potiuk]

Geee. It's far too easy to make those duplicate licences.

I think we should fork the licence plugin and make it so that it will try to find if there is an imperfect match and fail the build rather than add licence in this case (with some helpful comment added like "Please delete the licence so that we can add it properly). WDYT @mik-laj @ashb ? . It's mostly a transition problem (because people will start creating new files and copy licences from existing files) but in case there are other means of adding licences (for example plugins in their IDEs) we might end up with a lot of duplicated licences.

[potiuk]

All should be fixed now.

[mik-laj]

I don't think this is a big problem. The duplicate license is very large and easy to see in new files. I think, it is over engineering, but let's wait what time shows.

[potiuk]

I actually thought it's not that difficult, and it was not. Along the way I fixed a few annoyances with the pre-commit insert-licences. (fuzzy matching, inserting after shebang/ possibility to disable license inserting via comment in the file). I added all tests/documentation and opened PR to Lucas-C's repository (Lucas-C/pre-commit-hooks#12) - hopefully it will make it into 1.1.7 release of his plugin. For now I switched the licence plugins to my fork.

[potiuk]

Are you OK to merge @mik-laj @ashb. I solved the problem of duplicate licences now - the modified version of the insert-license plugin is now taken from my repo and it's much smarter now + it informs which files were modified + you can disable license insertion for files via appropriate comment. Lots of tests added . I tested it on the parent of this commit and it correctly added new licenses and TODOs where licences were inconsistent with this comment:

--- a/airflow/www/templates/appbuilder/flash.html
+++ b/airflow/www/templates/appbuilder/flash.html
@@ -1,4 +1,6 @@
 {#
+ TODO: This license is not consistent with license used in the project.
+       Delete the inconsistent license and above line and rerun pre-commit to insert good license.
   Licensed to the Apache Software Foundation (ASF) under one or more
   contributor license agreements.  See the NOTICE file distributed with
   this work for additional information regarding copyright ownership.

It will prevent committing until you delete all offending licenses and re-insert licenses.

[milton0825]

LGTM