Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5239] Fix listing of pylint test scripts for Docker container #5844

Conversation

coopergillan
Copy link
Contributor

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

    1. List the two separate pylint scripts for use inside the Docker containers in CONTRIBUTING.md, not a single one that appears to no longer exist.
    2. Fix a small typo in another spot of CONTRIBUTING.md

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • These are only docs changes

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

List the two separate pylint scripts for use inside the Docker
containers in CONTRIBUTING.md.
@potiuk potiuk merged commit a47292d into apache:master Aug 17, 2019
potiuk pushed a commit that referenced this pull request Aug 17, 2019
List the two separate pylint scripts for use inside the Docker
containers in CONTRIBUTING.md.

(cherry picked from commit a47292d)
@potiuk
Copy link
Member

potiuk commented Aug 17, 2019

Thanks @coopergillan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants