Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5260] Allow empty uri arguments in connection strings #5855

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

sb2nov
Copy link
Contributor

@sb2nov sb2nov commented Aug 19, 2019

Allow empty string arguments in the connection string. This is needed if you're connecting to RDS using IAM role instead of a password then we would want to pass the aws_conn_id argument as empty.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Allow empty string arguments in the connection string. This is needed if you're connecting to RDS using IAM role instead of a password then we would want to pass the aws_conn_id argument as empty.

Tests

  • Added unittest

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • [] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mik-laj
Copy link
Member

mik-laj commented Aug 19, 2019

HI.
Your change is wonderful, but every code change needs a ticket. Can you create it?

Best

@sb2nov sb2nov changed the title [AIRFLOW-XXX] Allow empty uri arguments in connection strings [AIRFLOW-5260] Allow empty uri arguments in connection strings Aug 19, 2019
@sb2nov
Copy link
Contributor Author

sb2nov commented Aug 19, 2019

Thanks for the review, created the JIRA issue. Should be ready to merge now.

@kaxil kaxil merged commit 7fb729d into apache:master Aug 20, 2019
kaxil pushed a commit that referenced this pull request Aug 20, 2019
@kaxil
Copy link
Member

kaxil commented Aug 20, 2019

Thanks @sb2nov

potiuk pushed a commit that referenced this pull request Aug 20, 2019
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants