Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4768] Add timeout parameter to Cloud Video Intelligence operators #5862

Merged

Conversation

turbaszek
Copy link
Member

@turbaszek turbaszek commented Aug 19, 2019

This commit adds timeout parameter to GCP Video Intelligence operators

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This PR adds timeout parameter to GCP Video Intelligence operators

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

This commit adds timeout parameter to GCP Video Intelligence operators
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Aug 20, 2019
@mik-laj mik-laj changed the title [AIRFLOW-4768] Timeout parameter in example_gcp_video_intelligence [AIRFLOW-4768] Add timeout parameter to Cloud Video Intelligence operators Aug 22, 2019
@mik-laj mik-laj merged commit 2d46d5f into apache:master Aug 22, 2019
kaxil pushed a commit that referenced this pull request Aug 30, 2019
kaxil pushed a commit that referenced this pull request Aug 30, 2019
kaxil pushed a commit that referenced this pull request Aug 30, 2019
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
@turbaszek turbaszek deleted the gcp-video-intelligence-timeout branch September 19, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants