Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1523] Clicking on Graph View should display related DAG run #5866

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

JCoder01
Copy link
Contributor

Add execution_date_arg
Use execution_date_arg in graph, gantt, and Back To {parent.dag} links.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-1523
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Currently, in the dag view, execution_date is not included as query param for the Graph or Gantt Chart views. It also is not included as part of the Back To {{ parentdag }} link. This PR adds execution_date to the query params;

Before:

image

After:

image

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Current tests cover changes

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

Add execution_date_arg
Use execution_date_arg in graph, gantt, and Back To {parent.dag} links.

Add check of execution date
@kaxil kaxil requested a review from ashb August 20, 2019 11:21
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But tagging in @ashb as well.

@ashb ashb merged commit 835eadf into apache:master Aug 20, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Aug 20, 2019
…(RBAC only) (apache#5866)

Add execution_date_arg
Use execution_date_arg in graph, gantt, and Back To {parent.dag} links.

Add check of execution date

(cherry picked from commit 835eadf)
@JCoder01 JCoder01 deleted the airflow-1523-execution-date branch August 29, 2019 15:20
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
…pache#5866)

Add execution_date_arg
Use execution_date_arg in graph, gantt, and Back To {parent.dag} links.

Add check of execution date
@kaxil kaxil modified the milestone: Airflow 1.10.11 May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants