-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5313] Add params support for awsbatch_operator #5900
Conversation
Can you make a jira and make the commit start with |
Please squash commits into one feature-commit |
377bee8
to
2d50421
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - if the CI can pass
Unless I'm mistaken, the CI error doesn't appear to be related to this code update. What's the best way to re-run it? |
2d50421
to
36ec76c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5900 +/- ##
==========================================
- Coverage 83.79% 83.35% -0.44%
==========================================
Files 669 669
Lines 37560 37561 +1
==========================================
- Hits 31472 31310 -162
- Misses 6088 6251 +163
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - and the CI is passing now.
Please also fix the conflicts and rebase onto master. Thanks 👍 :) |
36ec76c
to
57e2dd6
Compare
57e2dd6
to
a19eacc
Compare
The boto3 url has been fixed and the PR has been rebased on master. What else needs to be addressed before this can be merged? |
Make sure you have checked all steps below.
Jira
Description
AWS Batch supports passing parameters to jobs, and this update enables that functionality in the
AWSBatchOperator
.Tests
tests/contrib/operators/test_awsbatch_operator.py
has been updated to includeparameters
.Commits
Documentation
Code Quality
flake8