Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5313] Add params support for awsbatch_operator #5900

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

jrowen
Copy link
Contributor

@jrowen jrowen commented Aug 23, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

AWS Batch supports passing parameters to jobs, and this update enables that functionality in the AWSBatchOperator.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

tests/contrib/operators/test_awsbatch_operator.py has been updated to include parameters.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mik-laj mik-laj added provider:google Google (including GCP) related issues provider:amazon-aws AWS/Amazon - related issues and removed provider:google Google (including GCP) related issues labels Aug 23, 2019
@milton0825
Copy link
Contributor

Can you make a jira and make the commit start with [AIRFLOW-<jira-number>]

@jrowen jrowen changed the title [AIRFLOW-XXX] Add params support for awsbatch_operator [AIRFLOW-5313] Add params support for awsbatch_operator Aug 26, 2019
@dazza-codes
Copy link
Contributor

Please squash commits into one feature-commit

@jrowen jrowen force-pushed the jrowen-awsbatch-params branch 3 times, most recently from 377bee8 to 2d50421 Compare August 27, 2019 17:33
Copy link
Contributor

@dazza-codes dazza-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if the CI can pass

@jrowen
Copy link
Contributor Author

jrowen commented Aug 29, 2019

Unless I'm mistaken, the CI error doesn't appear to be related to this code update. What's the best way to re-run it?

@codecov-io
Copy link

codecov-io commented Sep 9, 2019

Codecov Report

Merging #5900 into master will decrease coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5900      +/-   ##
==========================================
- Coverage   83.79%   83.35%   -0.44%     
==========================================
  Files         669      669              
  Lines       37560    37561       +1     
==========================================
- Hits        31472    31310     -162     
- Misses       6088     6251     +163
Impacted Files Coverage Δ
airflow/contrib/operators/awsbatch_operator.py 78.65% <100%> (+0.24%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/executors/sequential_executor.py 47.61% <0%> (-52.39%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 77.14% <0%> (-21.43%) ⬇️
airflow/utils/sqlalchemy.py 86.44% <0%> (-6.78%) ⬇️
airflow/jobs/local_task_job.py 85% <0%> (-5%) ⬇️
airflow/executors/__init__.py 63.26% <0%> (-4.09%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a344f1...a19eacc. Read the comment docs.

Copy link
Contributor

@dazza-codes dazza-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - and the CI is passing now.

@feluelle
Copy link
Member

Please also fix the conflicts and rebase onto master. Thanks 👍 :)

@jrowen
Copy link
Contributor Author

jrowen commented Nov 20, 2019

The boto3 url has been fixed and the PR has been rebased on master. What else needs to be addressed before this can be merged?

@feluelle feluelle merged commit 01a15b8 into apache:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants