Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5302] Fix bug in none_skipped Trigger Rule #5902

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Aug 23, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    The task been set none_skipped run immediately even before upstream tasks complete execution.
    Bug:
    none_skipped_trigger_rule

After Fix:
Waits till upstream tasks are complete / skipped and skips if all upstream tasks have skipped
fixed_none_skipped

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Added

Commits

  • [z] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@kaxil kaxil requested review from ashb, potiuk and mik-laj August 23, 2019 19:53
Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting bug. It made me analyze how exactly the trigger rules work. I once wanted to add tables to documentation that show how trigger rules behave in more cases. I will have to come back to this, because it may be a more interesting topic than it seems at first glance.

@kaxil kaxil merged commit f14947c into apache:master Aug 24, 2019
kaxil added a commit that referenced this pull request Aug 30, 2019
kaxil added a commit that referenced this pull request Aug 30, 2019
@kaxil kaxil deleted the fix-none-skipped branch August 30, 2019 20:39
kaxil added a commit that referenced this pull request Aug 30, 2019
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants