Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5304] Fix extra links in BigQueryOperator with multiple queries #5906

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Aug 24, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5304
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

CC: @milton0825

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mik-laj mik-laj force-pushed the AIRFLOW-5304 branch 2 times, most recently from 054a8ef to 403737a Compare August 24, 2019 11:36
@mik-laj mik-laj changed the title [AIRFLOW-5304] Fix extra links in BigQueryOperator for task with muliple queriess [AIRFLOW-5304][depends on AIRFLOW-5306]] Fix extra links in BigQueryOperator for task with muliple queriess Aug 24, 2019
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Aug 24, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5304][depends on AIRFLOW-5306]] Fix extra links in BigQueryOperator for task with muliple queriess [AIRFLOW-5304][depends on AIRFLOW-5306] Fix extra links in BigQueryOperator for task with muliple queriess Aug 24, 2019
if len(job_ids) < self.index:
return None
job_id = job_ids[self.index]
return 'https://console.cloud.google.com/bigquery?j={job_id}'.format(job_id=job_id)
Copy link
Contributor

@milton0825 milton0825 Aug 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we extract this string to a template and reuse it in line 44?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. :-D

Copy link
Contributor

@milton0825 milton0825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a small nit. I am glad people are using the extra link feature 😄

@mik-laj
Copy link
Member Author

mik-laj commented Aug 25, 2019

I would like GCP operators to better support these feature. I hope that we will be able to find hours in the near future to add support for this. I hope to find hours in the near future to add support for this feature to more operators. I am currently working on one set of operators and It will implement this functionality.

@mik-laj mik-laj changed the title [AIRFLOW-5304][depends on AIRFLOW-5306] Fix extra links in BigQueryOperator for task with muliple queriess [AIRFLOW-5304][depends on AIRFLOW-5306] Fix extra links in BigQueryOperator for task with multiple queries Aug 27, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5304][depends on AIRFLOW-5306] Fix extra links in BigQueryOperator for task with multiple queries [AIRFLOW-5304][depends on AIRFLOW-5306] Fix extra links in BigQueryOperator with multiple queries Aug 27, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5304][depends on AIRFLOW-5306] Fix extra links in BigQueryOperator with multiple queries [AIRFLOW-5304] Fix extra links in BigQueryOperator with multiple queries Aug 27, 2019
@mik-laj mik-laj merged commit 6b8e135 into apache:master Aug 27, 2019
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
ashb pushed a commit that referenced this pull request Dec 18, 2019
ashb pushed a commit that referenced this pull request Dec 19, 2019
kaxil pushed a commit that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants