-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5304] Fix extra links in BigQueryOperator with multiple queries #5906
Conversation
054a8ef
to
403737a
Compare
if len(job_ids) < self.index: | ||
return None | ||
job_id = job_ids[self.index] | ||
return 'https://console.cloud.google.com/bigquery?j={job_id}'.format(job_id=job_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we extract this string to a template and reuse it in line 44?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from a small nit. I am glad people are using the extra link feature 😄
…th multiple queriess
I would like GCP operators to better support these feature. I hope that we will be able to find hours in the near future to add support for this. I hope to find hours in the near future to add support for this feature to more operators. I am currently working on one set of operators and It will implement this functionality. |
Make sure you have checked all steps below.
Jira
Description
CC: @milton0825
Tests
Commits
Documentation
Code Quality
flake8