Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5323] Fix teething proglems breeze #5933

Merged
merged 7 commits into from
Aug 28, 2019

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 28, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Issues discovered during first Breeze workshop (AKA Teething problems).

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk
Copy link
Member Author

potiuk commented Aug 28, 2019

Small but annoying issues I was able to discover when I tried it with the attendees of NYC Apache Airflow Meetup. I split it to separate issues but submit it as one PR to make it easier/faster to merge.


*
Latest stable Docker Community Edition installed and on the PATH. It should be
configured to be able to run ``docker`` commands directly and not only via root user
configured to be able to run ``docker`` commands directly and not only via root user. You user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
configured to be able to run ``docker`` commands directly and not only via root user. You user
configured to be able to run ``docker`` commands directly and not only via root user. Your user

@kaxil kaxil changed the title Fix teething proglems breeze [AIRFLOW-5323] Fix teething proglems breeze Aug 28, 2019
@potiuk potiuk merged commit f98867c into apache:master Aug 28, 2019
@kaxil kaxil mentioned this pull request Aug 28, 2019
6 tasks
@potiuk potiuk deleted the fix-teething-proglems-breeze branch September 20, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants