Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5357] Fix Content-Type for exported variables.json file #5963

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Aug 30, 2019

This PR is targeted to v1-10-test

Make sure you have checked all steps below.

Jira

Description

Credits to Anurag Jain for reporting this:
It was observed that the content type is set incorrectly while exporting variables in Apache Airflow.

Steps:

Open the Apache Airflow
Create a new variable at /admin/variable/
Keep the key as and value as
Save this variable
Export this variable using Mozilla Firefox Browser
Observe that the downloaded file is saved as .json.htm instead of .json. This happens since Apache airflow sets Response Content-Type as text/html instead of application/json which causes Browser to interpret it as a HTML

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@kaxil
Copy link
Member Author

kaxil commented Aug 30, 2019

Passed in my local fork: https://travis-ci.org/kaxil/airflow/builds/578820954

@kaxil kaxil merged commit 3fbc519 into apache:v1-10-stable Aug 30, 2019
@kaxil kaxil deleted the v1-10-test branch August 30, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant