Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Make Breeze The default integration test environment #6001

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 4, 2019

Make sure you have checked all steps below.

Jira

  • [x ] My PR addresses the following Airflow Jira - In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk
Copy link
Member Author

potiuk commented Sep 4, 2019

This change clearly separates two development environments we have - Local Virtualenv and Breeze. This was a prerequisite I agreed with Elena to work on improving the documentation as a whole - now after Breeze has gone through teething problems we can make it clear that it can and should be used for running integration tests and local virtualenv should be used for local development/running unit tests.

@potiuk potiuk changed the title [AIRFLOW-XXX] Make Breeze The default test environment [AIRFLOW-XXX] Make Breeze The default integration test environment Sep 4, 2019
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@milton0825 milton0825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one small nit.

@potiuk potiuk merged commit 9278f79 into apache:master Sep 5, 2019
potiuk added a commit that referenced this pull request Sep 5, 2019
…6001)

* [AIRFLOW-XXX] Make Breeze The default integration test environment
Co-Authored-By: Chao-Han Tsai <[email protected]>

(cherry picked from commit 9278f79)
@potiuk potiuk deleted the update-breeze-docs branch September 19, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants