Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5530] Fiix typo in AWS SQS sensors #6012

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Conversation

Mistobaan
Copy link
Contributor

@Mistobaan Mistobaan commented Sep 4, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5530
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@feluelle
Copy link
Member

Welcome @Mistobaan :)

Sorry to be picky, but code changes always need a Jira ticket. It helps us to keep track of changes as we also mention these changes/tickets in the release notes.
Even log statements are functionality. Some of them even get tested - not in this specific case.

Do you mind open a ticket for this even it looks so simple? The commit message should then start with [AIRFLOW-ticket_number]. After you have done this let me know and I am happy to merge it. Thanks.

@mik-laj mik-laj changed the title nip typo [AIRFLOW-5530] Fiix typo in AWS SQS sensors Sep 21, 2019
@mik-laj
Copy link
Member

mik-laj commented Sep 21, 2019

I created a missing jira ticket.

@mik-laj mik-laj added the provider:amazon-aws AWS/Amazon - related issues label Sep 21, 2019
@mik-laj mik-laj merged commit 123479c into apache:master Sep 21, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Oct 14, 2019
adityav pushed a commit to adityav/airflow that referenced this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants