Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5408] Fix env variable name in Kubernetes template #6016

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

qlemaire22
Copy link

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

I fix a variable name in https://github.com/apache/airflow/blob/master/scripts/ci/kubernetes/kube/templates/airflow.template.yaml to match the name of the configuration value, it had no impact before.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the k8s label Sep 5, 2019
@OmerJog
Copy link
Contributor

OmerJog commented Sep 24, 2019

The tests report these errors:

tests/contrib/hooks/test_bigquery_hook.py:62: error: Name 'PropertyMock' is not defined
tests/contrib/hooks/test_bigquery_hook.py:73: error: Name 'PropertyMock' is not defined
tests/contrib/hooks/test_bigquery_hook.py:84: error: Name 'PropertyMock' is not defined
tests/contrib/hooks/test_bigquery_hook.py:94: error: Name 'PropertyMock' is not defined
tests/contrib/hooks/test_bigquery_hook.py:105: error: Name 'PropertyMock' is not defined

@mik-laj do you know why?

@mik-laj mik-laj self-requested a review September 24, 2019 07:02
@dimberman
Copy link
Contributor

Ahh good catch thanks @qlemaire22

@codecov-io
Copy link

Codecov Report

Merging #6016 into master will decrease coverage by 70.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #6016       +/-   ##
==========================================
- Coverage   80.02%   9.58%   -70.44%     
==========================================
  Files         594     610       +16     
  Lines       34769   35212      +443     
==========================================
- Hits        27824    3376    -24448     
- Misses       6945   31836    +24891
Impacted Files Coverage Δ
...low/contrib/operators/wasb_delete_blob_operator.py 0% <0%> (-100%) ⬇️
airflow/example_dags/subdags/subdag.py 0% <0%> (-100%) ⬇️
airflow/gcp/sensors/bigquery_dts.py 0% <0%> (-100%) ⬇️
airflow/gcp/operators/text_to_speech.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/emr_base_sensor.py 0% <0%> (-100%) ⬇️
airflow/example_dags/example_subdag_operator.py 0% <0%> (-100%) ⬇️
airflow/contrib/operators/file_to_gcs.py 0% <0%> (-100%) ⬇️
airflow/gcp/hooks/kms.py 0% <0%> (-100%) ⬇️
airflow/contrib/hooks/gcp_spanner_hook.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/cassandra_record_sensor.py 0% <0%> (-100%) ⬇️
... and 526 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebffd39...d18285d. Read the comment docs.

@potiuk potiuk merged commit d70c5fd into apache:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants