Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5492] added missing docstrings #6107

Merged
merged 1 commit into from
Sep 15, 2019
Merged

[AIRFLOW-5492] added missing docstrings #6107

merged 1 commit into from
Sep 15, 2019

Conversation

neuralgremlin
Copy link
Contributor

@neuralgremlin neuralgremlin commented Sep 15, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@neuralgremlin
Copy link
Contributor Author

@jghoman

@jghoman
Copy link
Member

jghoman commented Sep 15, 2019

+1. Thanks for the contribution, Pedro! Welcome to Airflow.

@jghoman jghoman merged commit 3c064d4 into apache:master Sep 15, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Oct 14, 2019
adityav pushed a commit to adityav/airflow that referenced this pull request Oct 14, 2019
@neuralgremlin neuralgremlin deleted the AIRFLOW-5492 branch October 18, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants