Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5503] Fix tree view layout on HDPI screen #6125

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

robinedwards
Copy link
Contributor

@robinedwards robinedwards commented Sep 16, 2019

  • Use window.devicePixelRatio to apply a multiplier to the existing dimensions falling back to 1 if its not available

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Manually tested, very difficult to unit test screen layout.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

- Tree view layout on HDPI screens overlaps and doesn't make full use of
screen real estate.
Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love it! 👍

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #6125 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6125      +/-   ##
==========================================
- Coverage   80.12%   80.12%   -0.01%     
==========================================
  Files         607      607              
  Lines       34905    34905              
==========================================
- Hits        27967    27966       -1     
- Misses       6938     6939       +1
Impacted Files Coverage Δ
airflow/jobs/scheduler_job.py 74.28% <0%> (-0.31%) ⬇️
airflow/utils/dag_processing.py 58.98% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2a07...818b1ce. Read the comment docs.

@kaxil kaxil merged commit 533086e into apache:master Sep 16, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Oct 14, 2019
- Tree view layout on HDPI screens overlaps and doesn't make full use of
screen real estate.

(cherry picked from commit 533086e)
adityav pushed a commit to adityav/airflow that referenced this pull request Oct 14, 2019
- Tree view layout on HDPI screens overlaps and doesn't make full use of
screen real estate.

(cherry picked from commit 533086e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants