Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Add a third way to configure authorization #6134

Merged
merged 1 commit into from
Sep 21, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Sep 17, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added provider:google Google (including GCP) related issues docs-only-change labels Sep 17, 2019
@codecov-io
Copy link

Codecov Report

Merging #6134 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6134      +/-   ##
==========================================
+ Coverage      80%   80.03%   +0.02%     
==========================================
  Files         607      607              
  Lines       35006    35085      +79     
==========================================
+ Hits        28007    28079      +72     
- Misses       6999     7006       +7
Impacted Files Coverage Δ
airflow/contrib/hooks/grpc_hook.py 92.06% <0%> (-1.27%) ⬇️
airflow/operators/docker_operator.py 95.74% <0%> (-1%) ⬇️
airflow/models/taskinstance.py 93.22% <0%> (-0.51%) ⬇️
airflow/models/baseoperator.py 95.1% <0%> (-0.25%) ⬇️
airflow/kubernetes/pod.py 91.66% <0%> (ø) ⬆️
airflow/api/auth/backend/kerberos_auth.py 84% <0%> (ø) ⬆️
airflow/utils/strings.py 100% <0%> (ø) ⬆️
airflow/gcp/operators/mlengine.py 75.72% <0%> (ø) ⬆️
airflow/exceptions.py 100% <0%> (ø) ⬆️
airflow/gcp/hooks/mlengine.py 20.66% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26aa4ba...383278a. Read the comment docs.

@mik-laj mik-laj requested a review from potiuk September 17, 2019 12:39
@potiuk potiuk merged commit 38ebc42 into apache:master Sep 21, 2019
potiuk pushed a commit that referenced this pull request Sep 21, 2019
ashb pushed a commit that referenced this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants