Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Fix incorrect units in docs for metrics using Timers #6152

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Sep 19, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

https://statsd.readthedocs.io/en/v2.1.2/timing.html - Stats timers would emit time in milliseconds.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    n/a - doc change

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested review from feng-tao, milton0825 and ashb and removed request for feng-tao September 19, 2019 14:23
@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #6152 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6152      +/-   ##
==========================================
+ Coverage   80.05%   80.05%   +<.01%     
==========================================
  Files         607      607              
  Lines       35044    35044              
==========================================
+ Hits        28054    28055       +1     
+ Misses       6990     6989       -1
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 58.98% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6045a...0228991. Read the comment docs.

@feng-tao feng-tao merged commit ee1a346 into apache:master Sep 19, 2019
@kaxil kaxil deleted the fix-doc-metrics branch September 21, 2019 01:44
ashb pushed a commit to ashb/airflow that referenced this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants