Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Fix backtick issues in .rst files & Add Precommit hook #6162

Merged
merged 2 commits into from
Sep 21, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Sep 21, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    [AIRFLOW-XXX] Fix backtick issues in .rst files & Add Precommit hook

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    doc only change

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested a review from potiuk September 21, 2019 19:07
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ❤️

@kaxil
Copy link
Member Author

kaxil commented Sep 21, 2019

@kaxil kaxil merged commit cfd8d60 into apache:master Sep 21, 2019
@kaxil kaxil deleted the single-ticks branch September 21, 2019 19:47
potiuk pushed a commit that referenced this pull request Sep 22, 2019
potiuk pushed a commit that referenced this pull request Sep 22, 2019
ashb pushed a commit that referenced this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants