[AIRFLOW-5560] Allow no confirmation on reset dags

[robinedwards]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-5560] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-5560

Description

• Here are some details about my PR, including screenshots of any UI changes:

When using the backfill command with the --reset_dags option there is a confirmation prompt and no way to suppress it. I've wired in the --yes parameter to do this, note that using --no_confirm wasn't an option as thats aliased to '-c' which is used for --conf in the backfill sub command.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

No tests for command line arguments, tested locally though.

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.

  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

• Done automatically via argparse

[feng-tao]

is there a reason to suppress it as not everyone is familiar with this input arg? this will provide a safety guard to allow users know what will get clear during backfill.

[robinedwards]

Yes when running the command from a BashOperator for instance I need a way of surpressing the input. The flag is documented.

[codecov-io]

Codecov Report

Merging #6195 into v1-10-stable will decrease coverage by <.01%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           v1-10-stable    #6195      +/-   ##
================================================
- Coverage         76.53%   76.52%   -0.01%     
================================================
  Files               509      509              
  Lines             34352    34352              
================================================
- Hits              26291    26289       -2     
- Misses             8061     8063       +2

Impacted Files	Coverage Δ
airflow/bin/cli.py	62.59% <ø> (ø)	⬆️
airflow/utils/dag_processing.py	56.97% <0%> (-0.35%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06a956...d1df354. Read the comment docs.

[feng-tao]

ok, but the flag name is too generic, yes to ? How about --suppress_prompt ?
cc @ashb

[robinedwards]

I only chose --yes because it was already being used:

https://github.com/apache/airflow/blob/master/airflow/bin/cli.py#L1711

But I would be happy to change it to whatever you guys can agree on as long as its consistent

Note that the PR for master also updates clear to also use --yes #6197.

[ashb]

--yes feels more familiar to be, at least that's what apt-get install --yes uses.

[ashb]

Oh and --yes is what we already use for no-confirm on db reset/resetdb

[robinedwards]

Any conclusion on this?

[ashb]

Taking silence as assent :)