Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5572] Clear task reschedules when clearing task instances #6217

Conversation

feluelle
Copy link
Member

@feluelle feluelle commented Sep 30, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5572
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Currently when you clear tasks the clear mechanism won't delete reschedule entries related to the task instance from the db.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@feluelle feluelle changed the title [AIRFLOW-5572] Clearing Task Instances with reschedule mode does not … [AIRFLOW-5572] Clearing Task Instances with reschedule mode does not clear reschedules during up_for_reschedule Sep 30, 2019
@codecov-io
Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #6217 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6217      +/-   ##
==========================================
- Coverage   80.01%   79.93%   -0.09%     
==========================================
  Files         610      610              
  Lines       35176    35179       +3     
==========================================
- Hits        28147    28120      -27     
- Misses       7029     7059      +30
Impacted Files Coverage Δ
airflow/models/taskinstance.py 93.78% <100%> (+0.03%) ⬆️
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
airflow/hooks/postgres_hook.py 94.73% <0%> (-1.76%) ⬇️
airflow/utils/sqlalchemy.py 91.52% <0%> (-1.7%) ⬇️
airflow/hooks/dbapi_hook.py 86.44% <0%> (-1.7%) ⬇️
airflow/jobs/backfill_job.py 89.9% <0%> (-1.53%) ⬇️
airflow/utils/dag_processing.py 56.55% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781d001...da53048. Read the comment docs.

@feluelle feluelle changed the title [AIRFLOW-5572] Clearing Task Instances with reschedule mode does not clear reschedules during up_for_reschedule WIP: [AIRFLOW-5572] Clearing Task Instances with reschedule mode does not clear reschedules during up_for_reschedule Oct 4, 2019
@feluelle feluelle force-pushed the feature/AIRFLOW-5572-clearing-rescheduled-tasks branch from da53048 to 317b1bd Compare October 7, 2019 14:25
@feluelle feluelle changed the title WIP: [AIRFLOW-5572] Clearing Task Instances with reschedule mode does not clear reschedules during up_for_reschedule [AIRFLOW-5572] Clear task reschedules when clearing task instances Oct 7, 2019
@feluelle
Copy link
Member Author

feluelle commented Oct 7, 2019

Ready for re-Review :) @ashb @milton0825 @XD-DENG

Waiting for CI to get a green check mark :) - locally it breathed successfully

@milton0825 milton0825 merged commit ca24fdf into apache:master Oct 9, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Oct 10, 2019
@feluelle feluelle deleted the feature/AIRFLOW-5572-clearing-rescheduled-tasks branch April 30, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants