[AIRFLOW-5580] Add base class for system test #6229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6229 +/- ##
=========================================
- Coverage 80.05% 79.96% -0.1%
=========================================
Files 610 610
Lines 35264 35264
=========================================
- Hits 28232 28200 -32
- Misses 7032 7064 +32
Continue to review full report at Codecov.
|
5 tasks
kaxil
force-pushed
the
master
branch
2 times, most recently
from
558f9f1
to
d719e1f
Compare
|
It should be rebased to the latest master @nuclearpinguin |
|
@nuclearpinguin This PR contains too much commits. Can you fix it? |
turbaszek
force-pushed
the
add-system-test-base-class
branch
2 times, most recently
from
1034138
to
74e7526
Compare
turbaszek
force-pushed
the
add-system-test-base-class
branch
from
74e7526
to
c490399
Compare
ashb
reviewed
Oct 6, 2019
| dag_folder = resolve_dags_folder() | ||
| with empty_dags_directory(dag_folder): | ||
| db.upgradedb() | ||
| db.resetdb() |
There was a problem hiding this comment.
Resetdb does upgrade, there's no need to do both
This commit proposes base class for running system test in Airflow. The main concepts is to create an example DAG and run it for test purpose. This is especially important in case of integration with third party services.
turbaszek
force-pushed
the
add-system-test-base-class
branch
from
c490399
to
4437fc2
Compare
potiuk
approved these changes
Oct 7, 2019
potiuk
approved these changes
Oct 7, 2019
potiuk
pushed a commit
that referenced
this pull request
Oct 7, 2019
* [AIRFLOW-5580] Add base class for system test This commit proposes base class for running system test in Airflow. The main concepts is to create an example DAG and run it for test purpose. This is especially important in case of integration with third party services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
This PR proposes base class for running system test in Airflow. The
main concepts is to create an example DAG and run it for test purpose. This
is especially important in case of integration with third party services. The change is a part of refactor of GCP system test and aims to decouple running a test and handling authentication.
Tests
Commits
Documentation