Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5583] Extend the "DAG Details" page to display the start_date / end_date #6235

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

visciang
Copy link

@visciang visciang commented Oct 2, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Screenshot from 2019-10-02 11-37-01

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Actually there are no test around this view.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #6235 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6235      +/-   ##
==========================================
+ Coverage   80.05%   80.06%   +<.01%     
==========================================
  Files         610      610              
  Lines       35261    35261              
==========================================
+ Hits        28229    28230       +1     
+ Misses       7032     7031       -1
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 56.55% <0%> (-0.35%) ⬇️
airflow/models/taskinstance.py 93.75% <0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6fea6...16a67c4. Read the comment docs.

@kaxil kaxil force-pushed the master branch 2 times, most recently from 558f9f1 to d719e1f Compare October 2, 2019 15:30
@mik-laj
Copy link
Member

mik-laj commented Oct 3, 2019

@visciang This PR have a too much commits. Can you do a rebase?

@feluelle feluelle merged commit 25830a0 into apache:master Dec 9, 2019
kaxil pushed a commit that referenced this pull request Dec 18, 2019
ashb pushed a commit that referenced this pull request Dec 19, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants