-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-XXX] Improve format in code-block directives #6242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6242 +/- ##
==========================================
+ Coverage 80.06% 80.06% +<.01%
==========================================
Files 610 610
Lines 35261 35261
==========================================
+ Hits 28231 28232 +1
+ Misses 7030 7029 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion - but looks fine to me :)
@@ -28,7 +28,7 @@ can edit it to change any of the settings. You can also set options with environ | |||
For example, the | |||
metadata database connection string can either be set in ``airflow.cfg`` like this: | |||
|
|||
.. code-block:: bash | |||
.. code-block:: ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. code-block:: ini | |
.. code-block:: cfg |
works, too - according to http://pygments.org/docs/lexers/#pygments.lexers.configs.IniLexer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other place, we use ini
. I prefer not to introduce many ways to mark the same. https://raw.githubusercontent.com/apache/airflow/dd9071bf5e127d449eee304736d2a5125813f607/docs/usage-cli.rst
This is only information about the file format and pygments select this format by calling this class "Ini*". The information that cfg
is also supported is not obvious.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
(cherry picked from commit 6c13adb)
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation