Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-XXX] GSoD: Adding Task re-run documentation #6295
[AIRFLOW-XXX] GSoD: Adding Task re-run documentation #6295
Changes from all commits
62524e4
c4a4002
9731217
16a9222
fb01a3d
a169e9d
d545282
e068528
bab59ea
993d6fe
3bc8513
06926af
c5c281e
2ed9ba2
d6773ea
99675da
9948588
3569521
e82d0e6
65fea30
08be1dc
3bd602c
fcf03a6
cadc260
8178d37
52c8799
5c187a2
b6d8297
cd33fd1
17ccbf7
573563d
996b620
709c38d
ab93444
2840871
1c3d3e8
d3f00a3
863afe7
7595a42
5d85e2e
83afb44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to cli docs here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I remove the example and just have the CLI doc link or put CLI docs link below the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this probably makes more sense as a page under Concepts -- it doesn't fit with the rest of the top level items we have.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mik-laj and I were having a discussion on the same perspective that the concepts page needs to be broken down and some subpages need to move inside it. Since that would require changes in many pages, can we have that as part of another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can have a subpage like https://airflow.readthedocs.io/en/stable/howto/index.html and have different topics there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KKcorps What did we decide about this? Merge this PR as is then you split up concepts in to multiple pages afterwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, splitting up the page is a big effort. I think we should merge this and that split it up later.