Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Fix Documentation for adding extra Operator Links #6301

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 10, 2019

Make sure you have checked all steps below.

Jira

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Doc change

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested a review from ashb October 10, 2019 23:38
@codecov-io
Copy link

Codecov Report

Merging #6301 into master will decrease coverage by 70.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #6301       +/-   ##
==========================================
- Coverage   80.41%    9.5%   -70.91%     
==========================================
  Files         612     612               
  Lines       35473   35473               
==========================================
- Hits        28524    3372    -25152     
- Misses       6949   32101    +25152
Impacted Files Coverage Δ
...low/contrib/operators/wasb_delete_blob_operator.py 0% <0%> (-100%) ⬇️
airflow/example_dags/subdags/subdag.py 0% <0%> (-100%) ⬇️
airflow/gcp/sensors/bigquery_dts.py 0% <0%> (-100%) ⬇️
airflow/gcp/operators/text_to_speech.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/emr_base_sensor.py 0% <0%> (-100%) ⬇️
airflow/gcp/hooks/discovery_api.py 0% <0%> (-100%) ⬇️
airflow/contrib/operators/gcs_list_operator.py 0% <0%> (-100%) ⬇️
airflow/example_dags/example_subdag_operator.py 0% <0%> (-100%) ⬇️
airflow/contrib/operators/file_to_gcs.py 0% <0%> (-100%) ⬇️
airflow/gcp/hooks/kms.py 0% <0%> (-100%) ⬇️
... and 500 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9b44d...d976b6b. Read the comment docs.

@ashb ashb merged commit 568d804 into apache:master Oct 11, 2019
ashb pushed a commit that referenced this pull request Oct 11, 2019
ashb pushed a commit that referenced this pull request Oct 11, 2019
@kaxil kaxil deleted the fix-extra-link-doc branch November 29, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants