AIRFLOW-5126 Read aws_session_token in extra_config of the aws hook #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6303 +/- ##
==========================================
- Coverage 80.36% 80.35% -0.01%
==========================================
Files 616 616
Lines 35763 35765 +2
==========================================
- Hits 28740 28739 -1
- Misses 7023 7026 +3
Continue to review full report at Codecov.
|
ashb
reviewed
Oct 11, 2019
|
OKay @ashb I changed that and left it as implemented in the original does that work? |
ashb
requested changes
Oct 14, 2019
ashb
requested changes
Oct 14, 2019
ashb
reviewed
Oct 14, 2019
ashb
approved these changes
Oct 15, 2019
|
@jojo19893 What was your latest force-push for? You'd pushed over me removing a now "floating" comment. |
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Oct 16, 2019
…apache#6303) (cherry picked from commit d4e282d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Read a temporary token in case it is present this is important, if you don't manage the session token through
Airflowbut rather you use something like vault to manage these.Tests
adjusted existing test to also parse the session token not other impact.