[AIRFLOW-5634] Don't allow editing of DagModelView #6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
force-pushed
the
disable-dagmodelview-edit
branch
from
c6f7e3c
to
54646f6
Compare
|
Similar to #6307 but for the RBAC UI this time (and I took a different approach here) |
feluelle
previously approved these changes
Oct 12, 2019
feluelle
requested changes
Oct 12, 2019
|
I think editing dag runs would then be a different ticket/PR. |
Most/all of these fields are not fur user editing, with the exception of Pause which is set in other ways, and if a user edits these it will just confuse the system. So lets disable the FAB edit form. (Not to mention that the form was broken because it didn't accept the last_scheduler_run as filled out.)
ashb
force-pushed
the
disable-dagmodelview-edit
branch
from
54646f6
to
edbb4d9
Compare
feluelle
approved these changes
Oct 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #6308 +/- ##
=========================================
Coverage ? 80.34%
=========================================
Files ? 616
Lines ? 35733
Branches ? 0
=========================================
Hits ? 28710
Misses ? 7023
Partials ? 0
Continue to review full report at Codecov.
|
ashb
added a commit
to ashb/airflow
that referenced
this pull request
Oct 14, 2019
Most/all of these fields are not fur user editing, with the exception of Pause which is set in other ways, and if a user edits these it will just confuse the system. So lets disable the FAB edit form. (Not to mention that the form was broken because it didn't accept the last_scheduler_run as filled out.) (cherry picked from commit c082065)
adityav
pushed a commit
to adityav/airflow
that referenced
this pull request
Oct 14, 2019
Most/all of these fields are not fur user editing, with the exception of Pause which is set in other ways, and if a user edits these it will just confuse the system. So lets disable the FAB edit form. (Not to mention that the form was broken because it didn't accept the last_scheduler_run as filled out.) (cherry picked from commit c082065)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Description
Most/all of these fields are not fur user editing, with the exception of
Pause which is set in other ways, and if a user edits these it will just
confuse the system.
So lets disable the FAB edit form.
(Not to mention that the form was broken because it didn't accept the
last_scheduler_run as filled out.)
If anyone feels this is worth keeping I can make the it work but not allow editing of most/all fields