Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-5640] fix get_email_address_list types #6315

Merged
merged 1 commit into from
Oct 18, 2019
Merged

[AIRFLOW-5640] fix get_email_address_list types #6315

merged 1 commit into from
Oct 18, 2019

Conversation

SaturnFromTitan
Copy link
Contributor

@SaturnFromTitan SaturnFromTitan commented Oct 12, 2019 •
edited
Loading

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5640
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@SaturnFromTitan SaturnFromTitan force-pushed the 5640_fix_to_email_list_types branch 2 times, most recently from 2052a38 to ac87ff9 Compare October 12, 2019 13:27
@SaturnFromTitan SaturnFromTitan marked this pull request as ready for review October 12, 2019 13:28
@codecov-io
Copy link

codecov-io commented Oct 12, 2019 •
edited
Loading

Codecov Report

Merging #6315 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6315      +/-   ##
==========================================
- Coverage   80.09%   80.09%   -0.01%     
==========================================
  Files         616      616              
  Lines       35795    35803       +8     
==========================================
+ Hits        28670    28676       +6     
- Misses       7125     7127       +2
Impacted Files Coverage Δ
airflow/models/baseoperator.py 95.62% <ø> (ø) ⬆️
airflow/utils/email.py 100% <100%> (ø) ⬆️
airflow/utils/dag_processing.py 58.56% <0%> (-0.34%) ⬇️
airflow/contrib/hooks/ssh_hook.py 88.39% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0790ede...c12e7f9. Read the comment docs.

feluelle
feluelle approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SaturnFromTitan
Copy link
Contributor Author

Btw, I don't understand the code coverage change report. The files where coverage drop is reported are not touched by this PR. The overall coverage shouldn't be impacted by this PR at all.

ashb
ashb requested changes Oct 14, 2019
View reviewed changes
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@SaturnFromTitan
Copy link
Contributor Author

Thanks for your comments @ashb! I addressed all of them - please have another look :)

@SaturnFromTitan
Copy link
Contributor Author

Ready for another check @feluelle and @ashb

ashb
ashb requested changes Oct 15, 2019
View reviewed changes
airflow/utils/email.py Outdated Show resolved Hide resolved
airflow/utils/email.py Outdated Show resolved Hide resolved
@SaturnFromTitan
Copy link
Contributor Author

🤦‍♂ Yes of course. Ready for another round @ashb - now with succeeding tests

@SaturnFromTitan SaturnFromTitan force-pushed the 5640_fix_to_email_list_types branch 9 times, most recently from 944ef40 to 1e7706b Compare October 18, 2019 09:24
@SaturnFromTitan
Copy link
Contributor Author

For the past 2 days I've been restarting the CI build over and over again - some tests are timing out nonetheless... From checking other PRs, this doesn't seem to be related to my code change.

@ashb Can you please have another look at my changes? Thanks!

@potiuk
Copy link
Member

potiuk commented Oct 18, 2019

Hey @SaturnFromTitan - please rebase to latest master - we've just merged a workaround for failing Kubernetes tests which should make your test pass (while working on a permanent fix)

@SaturnFromTitan
AIRFLOW-5640:Refactored get_email_address_list
c12e7f9 
* Refactored get_email_address_list to have a better
  separation between string handling and other iterables.
* Explicitely casting get_email_address_list argument
  to a list in case the argument was an iterable. This
  enables direct support for tuples, sets or the like.
* Fixed type annotation of email parameter of
  BaseOperator to show that iterables are directly
  supported.
* Added docstring entries for email, email_on_retry,
  email_on_failure and queue in BaseOperator.
@SaturnFromTitan
Copy link
Contributor Author

Thanks @potiuk - it worked! :)

like @ashb mentioned before, the PR is ready for another review now

ashb
ashb approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@ashb ashb merged commit 9ec562f into apache:master Oct 18, 2019
ashb pushed a commit that referenced this pull request Dec 14, 2019
@SaturnFromTitan @ashb
[AIRFLOW-5640] Document and test email parameters of BaseOperator (#…
88088e6 
…6315)

* Refactored get_email_address_list to have a better
  separation between string handling and other iterables.
* Explicitely casting get_email_address_list argument
  to a list in case the argument was an iterable. This
  enables direct support for tuples, sets or the like.
* Fixed type annotation of email parameter of
  BaseOperator to show that iterables are directly
  supported.
* Added docstring entries for email, email_on_retry,
  email_on_failure and queue in BaseOperator.

(cherry picked from commit 9ec562f)
ashb pushed a commit that referenced this pull request Dec 16, 2019
@SaturnFromTitan @ashb
[AIRFLOW-5640] Document and test email parameters of BaseOperator (#…
b9ba719 
…6315)

* Refactored get_email_address_list to have a better
  separation between string handling and other iterables.
* Explicitely casting get_email_address_list argument
  to a list in case the argument was an iterable. This
  enables direct support for tuples, sets or the like.
* Fixed type annotation of email parameter of
  BaseOperator to show that iterables are directly
  supported.
* Added docstring entries for email, email_on_retry,
  email_on_failure and queue in BaseOperator.

(cherry picked from commit 9ec562f)
kaxil pushed a commit that referenced this pull request Dec 17, 2019
@SaturnFromTitan @kaxil
[AIRFLOW-5640] Document and test email parameters of BaseOperator (#…
12603b2 
…6315)

* Refactored get_email_address_list to have a better
  separation between string handling and other iterables.
* Explicitely casting get_email_address_list argument
  to a list in case the argument was an iterable. This
  enables direct support for tuples, sets or the like.
* Fixed type annotation of email parameter of
  BaseOperator to show that iterables are directly
  supported.
* Added docstring entries for email, email_on_retry,
  email_on_failure and queue in BaseOperator.

(cherry picked from commit 9ec562f)
ashb pushed a commit that referenced this pull request Dec 19, 2019
@SaturnFromTitan @ashb
[AIRFLOW-5640] Document and test email parameters of BaseOperator (#…
0fb3327 
…6315)

* Refactored get_email_address_list to have a better
  separation between string handling and other iterables.
* Explicitely casting get_email_address_list argument
  to a list in case the argument was an iterable. This
  enables direct support for tuples, sets or the like.
* Fixed type annotation of email parameter of
  BaseOperator to show that iterables are directly
  supported.
* Added docstring entries for email, email_on_retry,
  email_on_failure and queue in BaseOperator.

(cherry picked from commit 9ec562f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feluelle feluelle feluelle approved these changes

@ashb ashb ashb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SaturnFromTitan @codecov-io @potiuk @ashb @feluelle