Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Fix typo - AWS DynamoDB Hook #6319

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

SimonCW
Copy link
Contributor

@SimonCW SimonCW commented Oct 13, 2019

Description

  • Fix typo correcting that the hook is for DynamoDB not Athena. Well, it is my second PR overall and I have the feeling I produce more work than benefit with changes like this? Feedback appreciated 🌵

@SimonCW SimonCW changed the title Update aws_dynamodb_hook.py contrib-aws_dynamodb_hook - Fix typo Oct 13, 2019
@codecov-io
Copy link

codecov-io commented Oct 13, 2019

Codecov Report

Merging #6319 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6319      +/-   ##
==========================================
- Coverage   80.35%   80.11%   -0.25%     
==========================================
  Files         616      616              
  Lines       35735    35735              
==========================================
- Hits        28716    28628      -88     
- Misses       7019     7107      +88
Impacted Files Coverage Δ
airflow/contrib/hooks/aws_dynamodb_hook.py 91.3% <ø> (ø) ⬆️
airflow/operators/mysql_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_to_hive.py 0% <0%> (-100%) ⬇️
airflow/utils/sqlalchemy.py 86.44% <0%> (-6.78%) ⬇️
airflow/jobs/local_task_job.py 86.25% <0%> (-3.75%) ⬇️
airflow/hooks/hive_hooks.py 75.82% <0%> (-1.79%) ⬇️
airflow/models/connection.py 63.88% <0%> (-1.12%) ⬇️
airflow/hooks/dbapi_hook.py 87.28% <0%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c74ecb...c24b1db. Read the comment docs.

@mik-laj mik-laj changed the title contrib-aws_dynamodb_hook - Fix typo [AIRFLOW-XXX] Fix typo - AWS DynamoDB Hook Oct 13, 2019
@mik-laj
Copy link
Member

mik-laj commented Oct 13, 2019

Every patch is helpful. This does not cause much work, because the review of these changes is quick. Changes of this type are quickly accepted and become part of the project.

Similar changes created by me:
#6260
#6275
#6250
#6201
#6187
#6041
and many more.

@mik-laj mik-laj merged commit dfcf489 into apache:master Oct 13, 2019
@SimonCW
Copy link
Contributor Author

SimonCW commented Oct 14, 2019

Awesome, thanks so much for the feedback @mik-laj.

ashb pushed a commit to ashb/airflow that referenced this pull request Oct 14, 2019
adityav pushed a commit to adityav/airflow that referenced this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants