Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-XXX] Clarify daylight savings time behaviour #6324

Merged
merged 1 commit into from
Oct 25, 2019
Merged

[AIRFLOW-XXX] Clarify daylight savings time behaviour #6324

merged 1 commit into from
Oct 25, 2019

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Oct 13, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk
Copy link
Member

potiuk commented Oct 13, 2019

Hey @jmcarp ! Welcome back! I think there are some backtick problems in .rst files :)

@mik-laj mik-laj changed the title Clarify daylight savings time behavior. [AIRFLOW-XXX] Clarify daylight savings time behaviour Oct 13, 2019
ashb
ashb requested changes Oct 14, 2019
View reviewed changes
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the backticks :)

docs/timezone.rst Outdated
regardless if day light savings time is in place.

Time zone aware DAGs that use cron schedules respect daylight savings
time. For example, a DAG with a start date in the `US/Eastern` time zone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
time. For example, a DAG with a start date in the `US/Eastern` time zone
time. For example, a DAG with a start date in the ``US/Eastern`` time zone

docs/timezone.rst Outdated

Time zone aware DAGs that use cron schedules respect daylight savings
time. For example, a DAG with a start date in the `US/Eastern` time zone
with a schedule of `0 0 * * *` will run daily at 04:00 UTC during
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with a schedule of `0 0 * * *` will run daily at 04:00 UTC during
with a schedule of ``0 0 * * *`` will run daily at 04:00 UTC during

docs/timezone.rst Outdated
specify a ``timedelta(hours=2)`` you will always want to run two hours later. In this case day light savings time will
be taken into account.

Time zone aware DAGs that use `timedelta` or `relativedelta` schedules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Time zone aware DAGs that use `timedelta` or `relativedelta` schedules
Time zone aware DAGs that use ``timedelta`` or ``relativedelta`` schedules

docs/timezone.rst Outdated
Time zone aware DAGs that use `timedelta` or `relativedelta` schedules
respect daylight savings time for the start date but do not adjust for
daylight savings time when scheduling subsequent runs. For example, a
DAG with a start date of `pendulum.create(2020, 1, 1, tz="US/Eastern")`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DAG with a start date of `pendulum.create(2020, 1, 1, tz="US/Eastern")`
DAG with a start date of ``pendulum.create(2020, 1, 1, tz="US/Eastern")``

docs/timezone.rst Outdated
respect daylight savings time for the start date but do not adjust for
daylight savings time when scheduling subsequent runs. For example, a
DAG with a start date of `pendulum.create(2020, 1, 1, tz="US/Eastern")`
and a schedule interval of `timedelta(days=1)` will run daily at 05:00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and a schedule interval of `timedelta(days=1)` will run daily at 05:00
and a schedule interval of ``timedelta(days=1)`` will run daily at 05:00

@jmcarp jmcarp force-pushed the update-timezone-scheduling-docs branch from c184e6b to 0ada503 Compare October 21, 2019 15:38
@kaxil kaxil merged commit 52c2be5 into apache:master Oct 25, 2019
potiuk pushed a commit that referenced this pull request Oct 29, 2019
@jmcarp @potiuk
[AIRFLOW-XXX] Clarify daylight savings time behavior (#6324)
88720ae 
(cherry picked from commit 52c2be5)
potiuk pushed a commit that referenced this pull request Nov 12, 2019
@jmcarp @potiuk
[AIRFLOW-XXX] Clarify daylight savings time behavior (#6324)
f348fe9 
(cherry picked from commit 52c2be5)
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
@jmcarp @eladkal
[AIRFLOW-XXX] Clarify daylight savings time behavior (apache#6324)
f86651d 
(cherry picked from commit 52c2be5)
kaxil pushed a commit that referenced this pull request Dec 12, 2019
@jmcarp @kaxil
[AIRFLOW-XXX] Clarify daylight savings time behavior (#6324)
10a4392 
(cherry picked from commit 52c2be5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashb ashb ashb requested changes

@kaxil kaxil kaxil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmcarp @potiuk @ashb @kaxil @mik-laj