Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5665] Add path_exists method to SFTPHook #6344

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

TobKed
Copy link
Contributor

@TobKed TobKed commented Oct 16, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5665
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj
Copy link
Member

mik-laj commented Oct 16, 2019

I restarted travis jobs.

@codecov-io
Copy link

codecov-io commented Oct 20, 2019

Codecov Report

Merging #6344 into master will decrease coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6344      +/-   ##
=========================================
- Coverage   80.41%   80.1%   -0.31%     
=========================================
  Files         616     616              
  Lines       35808   35811       +3     
=========================================
- Hits        28794   28686     -108     
- Misses       7014    7125     +111
Impacted Files Coverage Δ
airflow/contrib/hooks/sftp_hook.py 93.82% <100%> (+0.23%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636aeb0...579c2af. Read the comment docs.

@TobKed TobKed requested a review from mik-laj October 21, 2019 13:34
@mik-laj mik-laj merged commit 44b6a27 into apache:master Oct 21, 2019
kaxil pushed a commit that referenced this pull request Dec 19, 2019
Co-Authored-By: Kamil Breguła <[email protected]>
(cherry picked from commit 44b6a27)
ashb pushed a commit that referenced this pull request Dec 19, 2019
Co-Authored-By: Kamil Breguła <[email protected]>
(cherry picked from commit 44b6a27)
kaxil pushed a commit that referenced this pull request Dec 19, 2019
Co-Authored-By: Kamil Breguła <[email protected]>
(cherry picked from commit 44b6a27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants