Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5693] Support the "blocks" component for the Slack messages #6364

Merged
merged 4 commits into from
Oct 20, 2019

Conversation

mingrammer
Copy link
Contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mingrammer
Copy link
Contributor Author

mingrammer commented Oct 19, 2019

CI failed due to this issue. (docker/for-linux#830)

And, this issue seems to be fixed. Please re-run the CI :) (docker/for-linux#830 (comment))

Err:13 https://download.docker.com/linux/debian stretch/stable amd64 Packages
  Writing more data than expected (11116 > 9983)
  Hashes of expected file:
   - Filesize:9983 [weak]
   - SHA512:4faf843dcb2544a9135a36ecfc4b914dd4e9cdada9a5e20e4994f5dd33d2d5aacb44f237bf9bf7048bac571e8be47d04975f8d93a19dab67dbfc231b68012011
   - SHA256:db9d0a054919cfa52440f1d59ec3f4f2fd15b89661c87f35f02a24f3832a6ce6
   - SHA1:d52b8071d1449718bc483c54a5bc698a26107aa6 [weak]
   - MD5Sum:d7b024e64ef3849c725f4ce1f05bf7a7 [weak]
  Release file created at: Sat, 17 Aug 2019 05:04:49 +0000

@feluelle
Copy link
Member

feluelle commented Oct 20, 2019

@mingrammer do you mind fixing another doc issue in it as well? 😀

See: https://airflow.readthedocs.io/en/latest/_api/airflow/contrib/hooks/slack_webhook_hook/index.html#airflow.contrib.hooks.slack_webhook_hook.SlackWebhookHook._build_slack_message

There is missing a blank line between the title and the param section in the _build_slack_message.

And this:

- :return: Slack message (str) to send
+ :return: Slack message to send
+ :rtype: str

After that I am happy to merge it when everything is green :)

@mingrammer
Copy link
Contributor Author

I fixed all docstring issues in this file!

@codecov-io
Copy link

codecov-io commented Oct 20, 2019

Codecov Report

Merging #6364 into master will decrease coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6364      +/-   ##
=========================================
- Coverage   80.41%   80.1%   -0.31%     
=========================================
  Files         616     616              
  Lines       35805   35808       +3     
=========================================
- Hits        28791   28683     -108     
- Misses       7014    7125     +111
Impacted Files Coverage Δ
airflow/contrib/hooks/slack_webhook_hook.py 95.83% <100%> (+0.27%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4903c97...85fb904. Read the comment docs.

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@feluelle feluelle merged commit 636aeb0 into apache:master Oct 20, 2019
@mingrammer mingrammer deleted the airflow-5693 branch October 20, 2019 12:48
kaxil pushed a commit that referenced this pull request Dec 14, 2019
kaxil pushed a commit that referenced this pull request Dec 14, 2019
kaxil pushed a commit that referenced this pull request Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants