[AIRFLOW-5658] Fix broken links when running behind reverse proxy #6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik-laj
reviewed
Oct 19, 2019
| @@ -3252,7 +3252,8 @@ tbody.collapse.in { | |||
| content: "\e223"; | |||
| } | |||
| .glyphicon-duplicate:before { | |||
| content: "\e224"; | |||
| font-family: "FontAwesome"; | |||
There was a problem hiding this comment.
This is an unrelated change. Can you revert it? We are working on full migration to font-awesome: #6254
There was a problem hiding this comment.
Sure, I wasn't aware this was taken care of already in a different PR
osule
force-pushed
the
5658-fix-broken-links
branch
from
cea77b0
to
cf162bb
Compare
Configuration and Version links are broken when running airflow behind reverse proxy. Registering navigation links through their respective views ensure that correct links are rendered in the menu.
osule
force-pushed
the
5658-fix-broken-links
branch
from
cf162bb
to
011ad08
Compare
Codecov Report
@@ Coverage Diff @@
## master #6374 +/- ##
==========================================
+ Coverage 80.39% 80.41% +0.01%
==========================================
Files 616 616
Lines 35804 35804
==========================================
+ Hits 28783 28790 +7
+ Misses 7021 7014 -7
Continue to review full report at Codecov.
|
milton0825
approved these changes
Oct 23, 2019
|
Ready to merge? |
kaxil
pushed a commit
that referenced
this pull request
Dec 17, 2019
Configuration and Version links are broken when running airflow behind reverse proxy. Registering navigation links through their respective views ensure that correct links are rendered in the menu.
ashb
pushed a commit
that referenced
this pull request
Dec 19, 2019
Configuration and Version links are broken when running airflow behind reverse proxy. Registering navigation links through their respective views ensure that correct links are rendered in the menu.
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jul 16, 2020
Configuration and Version links are broken when running airflow behind reverse proxy. Registering navigation links through their respective views ensure that correct links are rendered in the menu. (cherry picked from commit e77fa1a)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jul 16, 2020
Configuration and Version links are broken when running airflow behind reverse proxy. Registering navigation links through their respective views ensure that correct links are rendered in the menu. (cherry picked from commit e77fa1a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.Description
This fixes broken links to Configurations and Versions page when running Airflow behind reverse proxy.
Tests
Commits
Documentation
In case of new functionality, my PR adds documentation that describes how to use it.All the public functions and the classes in the PR contain docstrings that explain what it doesIf you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release