-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5727] SqoopHook: Build --connect parameter correctly when port/schema are not provided #6397
Conversation
airflow/contrib/hooks/sqoop_hook.py
Outdated
self.conn.port, | ||
self.conn.schema | ||
)] | ||
connect_str = "{}".format(self.conn.host) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just connect_str = self.conn.host
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated.
airflow/contrib/hooks/sqoop_hook.py
Outdated
connect_str += ":{}".format(self.conn.port) | ||
if self.conn.schema: | ||
connect_str += "/{}".format(self.conn.schema) | ||
connection_cmd += ["--connect", "{}".format(connect_str)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connection_cmd += ["--connect", connect_str]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated.
Codecov Report
@@ Coverage Diff @@
## master #6397 +/- ##
==========================================
- Coverage 84.25% 83.93% -0.32%
==========================================
Files 627 627
Lines 36506 36511 +5
==========================================
- Hits 30757 30646 -111
- Misses 5749 5865 +116
Continue to review full report at Codecov.
|
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation