Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5729] Make InputDataConfig optional in Sagemaker's training config #6398

Merged
merged 2 commits into from
Oct 28, 2019
Merged

[AIRFLOW-5729] Make InputDataConfig optional in Sagemaker's training config #6398

merged 2 commits into from
Oct 28, 2019

Conversation

BasPH
Copy link
Contributor

@BasPH BasPH commented Oct 23, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5729
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Config item InputDataConfig is optional to SageMaker, however the SageMakerTrainingOperator fails if it isn't provided (docs: https://docs.aws.amazon.com/sagemaker/latest/dg/API_CreateTrainingJob.html#SageMaker-CreateTrainingJob-request-InputDataConfig). This PR first checks if InputDataConfig is set.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

Merging #6398 into master will decrease coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6398      +/-   ##
==========================================
- Coverage   84.15%   83.91%   -0.24%     
==========================================
  Files         627      627              
  Lines       36537    36538       +1     
==========================================
- Hits        30746    30660      -86     
- Misses       5791     5878      +87
Impacted Files Coverage Δ
airflow/contrib/hooks/sagemaker_hook.py 87.25% <100%> (+0.05%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/jobs/local_task_job.py 85% <0%> (-5%) ⬇️
airflow/utils/dag_processing.py 58.48% <0%> (+0.32%) ⬆️
airflow/hooks/dbapi_hook.py 88.13% <0%> (+1.69%) ⬆️
airflow/utils/sqlalchemy.py 93.22% <0%> (+1.69%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4132f3b...f06495d. Read the comment docs.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test with and without ['InputDataConfig'], please ?

@BasPH
Copy link
Contributor Author

BasPH commented Oct 27, 2019

@kaxil added test case without InputDataConfig

@BasPH BasPH merged commit bdc5836 into apache:master Oct 28, 2019
@BasPH BasPH deleted the airflow-5729 branch October 28, 2019 21:37
kaxil pushed a commit that referenced this pull request Dec 19, 2019
…config (#6398)

* [AIRFLOW-5729] Make InputDataConfig optional in Sagemaker's training config

* Added test checking training config without InputDataConfig

(cherry picked from commit bdc5836)
ashb pushed a commit that referenced this pull request Dec 19, 2019
…config (#6398)

* [AIRFLOW-5729] Make InputDataConfig optional in Sagemaker's training config

* Added test checking training config without InputDataConfig

(cherry picked from commit bdc5836)
kaxil pushed a commit that referenced this pull request Dec 19, 2019
…config (#6398)

* [AIRFLOW-5729] Make InputDataConfig optional in Sagemaker's training config

* Added test checking training config without InputDataConfig

(cherry picked from commit bdc5836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants