-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5729] Make InputDataConfig optional in Sagemaker's training config #6398
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6398 +/- ##
==========================================
- Coverage 84.15% 83.91% -0.24%
==========================================
Files 627 627
Lines 36537 36538 +1
==========================================
- Hits 30746 30660 -86
- Misses 5791 5878 +87
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test with and without ['InputDataConfig']
, please ?
@kaxil added test case without |
…config (#6398) * [AIRFLOW-5729] Make InputDataConfig optional in Sagemaker's training config * Added test checking training config without InputDataConfig (cherry picked from commit bdc5836)
…config (#6398) * [AIRFLOW-5729] Make InputDataConfig optional in Sagemaker's training config * Added test checking training config without InputDataConfig (cherry picked from commit bdc5836)
…config (#6398) * [AIRFLOW-5729] Make InputDataConfig optional in Sagemaker's training config * Added test checking training config without InputDataConfig (cherry picked from commit bdc5836)
Make sure you have checked all steps below.
Jira
Description
Config item
InputDataConfig
is optional to SageMaker, however the SageMakerTrainingOperator fails if it isn't provided (docs: https://docs.aws.amazon.com/sagemaker/latest/dg/API_CreateTrainingJob.html#SageMaker-CreateTrainingJob-request-InputDataConfig). This PR first checks ifInputDataConfig
is set.Tests
Commits
Documentation