Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5766] Fix failing example_http_operator #6438

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

mingrammer
Copy link
Contributor

@mingrammer mingrammer commented Oct 26, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5766
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

Codecov Report

Merging #6438 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6438      +/-   ##
==========================================
+ Coverage   83.89%   83.91%   +0.01%     
==========================================
  Files         627      627              
  Lines       36529    36529              
==========================================
+ Hits        30647    30654       +7     
+ Misses       5882     5875       -7
Impacted Files Coverage Δ
airflow/utils/db.py 90.09% <ø> (ø) ⬆️
airflow/example_dags/example_http_operator.py 100% <ø> (ø) ⬆️
airflow/utils/dag_processing.py 58.48% <0%> (+0.32%) ⬆️
airflow/contrib/operators/ssh_operator.py 83.75% <0%> (+1.25%) ⬆️
airflow/jobs/local_task_job.py 90% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cc816d...b881aa3. Read the comment docs.

@feluelle
Copy link
Member

@mingrammer please also add a direct link to the jira ticket in the PR section "Jira" next time :)

@mingrammer
Copy link
Contributor Author

mingrammer commented Oct 28, 2019

Oh, I missed that :(. Yes, I'll do that next time!

@feluelle feluelle requested a review from mik-laj October 28, 2019 10:01
@feluelle feluelle merged commit 376f954 into apache:master Oct 28, 2019
@mingrammer mingrammer deleted the airflow-5766 branch October 28, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants