-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5803] Update S3Hook import paths [AIP-21] #6465
Conversation
dd0049d
to
cf251e3
Compare
Why did you add the AWS prefix? This is not in line with GCP operator naming guidelines. We have no general rules, so we can use the GCP if they make sense. Maybe you would like to help with creating a document describing the general principles of naming operators. I will gladly add my comments. A spreadsheet with planned changes would also be helpful. I have these for GCP changes. https://docs.google.com/document/d/1_rTdJSLCt0eyrAylmmgYc3yZr-_h51fVlnvMmWqhCkY/edit?ts=5bb72dfd# |
As I mentioned here #6455 (comment), I just followed the current class naming conventions for other AWS operators/hooks. So I'm a bit confused about which conventions I should follow. |
I am not sure of the correct solution. Can you write about this problem on mailing list? I don't think there has been an official discussion yet about ordering class names for AWS. The only document that describes it is AIP-21
My team has support from Google, so we have a plan that was presented in the integration guide. |
I sent a new thread on the mailing list about it! |
According to some threads on the above mail (all the conventions were proposed by @BasPH), I think we should keep the name So I'll fix the |
Done. |
Codecov Report
@@ Coverage Diff @@
## master #6465 +/- ##
==========================================
- Coverage 84.02% 83.39% -0.63%
==========================================
Files 632 635 +3
Lines 36640 36679 +39
==========================================
- Hits 30787 30590 -197
- Misses 5853 6089 +236
Continue to review full report at Codecov.
|
By the final voting result, It seems to have to move Should I update it with an another PR? |
Ah. My bad @mingrammer. I was too fast. Can you please make another one to move to amazon.aws ? |
I actually had to revert it as it was failing without rebase. Can you please rebase/reopen and add amazon package? |
Sure, I'll do! |
Related PR in #6764 for batch operator, so I need to follow all this API-21 stuff in a few places (although I'd prefer to just merge it and have the subsequent API-21 stuff applied in one larger PR, but looks like it's already piecemeal). |
If you want to do one large rename PR I'm all for it - ping me if you want a reviewer on it :) |
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation