[AIRFLOW-6058] Running tests with pytest #6472

turbaszek · 2019-10-30T14:29:49Z

Make sure you have checked all steps below.

Jira

My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6058

Description

Here are some details about my PR, including screenshots of any UI changes:

This PR switches nosetest to pytest. I tried to keep required changes to minimum.
What I have already learned is that:

many tests depend on database
order of tests is important
there are tests that create side effects in logging setup, local settings, config.

I am open to any suggestions and help.

Tests

My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters (not including Jira issue reference)
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

Documentation

In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

tests/conftest.py

setup.py

tests/conftest.py

feluelle · 2019-11-01T13:54:06Z

Oh just forgot it is not ready for review, sry 😬

feluelle · 2019-11-01T13:55:34Z

I can't wait to finally have pytest 😁

akki · 2019-11-20T15:51:24Z

Is there any place (JIRA ticket or discussion) where I can know why we want to move towards pytest?

turbaszek · 2019-11-20T15:57:48Z

@akki here is mail with AIP-27:
https://lists.apache.org/thread.html/484add15d555c717bab82553ba7e43a4e04f0d403ccf954406b382e7@%3Cdev.airflow.apache.org%3E

and some further discussion:
https://lists.apache.org/thread.html/ad6d7fce82b0a749e21066b6e5c3b80a5d59eca9166be86ceeaea05d@%3Cdev.airflow.apache.org%3E

airflow/utils/log/colored_log.py

airflow/www/views.py

setup.py

airflow/www/views.py

tests/conftest.py

potiuk

Some small comments.

airflow/www/views.py

setup.py

tests/conftest.py

tests/pytest.ini

tests/task/task_runner/test_standard_task_runner.py

tests/test_logging_config.py

tests/www/test_views.py

setup.py

tests/__init__.py

tests/pytest.ini

setup.py

tests/pytest.ini

tests/task/task_runner/test_standard_task_runner.py

codecov-io · 2019-11-26T11:06:45Z

Codecov Report

Merging #6472 into master will increase coverage by 0.73%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #6472      +/-   ##
==========================================
+ Coverage    83.9%   84.64%   +0.73%     
==========================================
  Files         668      669       +1     
  Lines       37687    37703      +16     
==========================================
+ Hits        31622    31912     +290     
+ Misses       6065     5791     -274

Impacted Files	Coverage Δ
airflow/www/views.py	`75.93% <ø> (-0.85%)`	⬇️
airflow/utils/log/colored_log.py	`89.58% <57.14%> (-3.6%)`	⬇️
airflow/executors/sequential_executor.py	`56% <0%> (-44%)`	⬇️
...low/ti_deps/deps/exec_date_after_start_date_dep.py	`80% <0%> (-10%)`	⬇️
airflow/executors/executor_loader.py	`59.09% <0%> (-6.82%)`	⬇️
airflow/utils/log/es_task_handler.py	`88.07% <0%> (-3.67%)`	⬇️
airflow/utils/sqlalchemy.py	`89.83% <0%> (-3.39%)`	⬇️
airflow/utils/log/s3_task_handler.py	`98.5% <0%> (-1.5%)`	⬇️
airflow/executors/base_executor.py	`96.05% <0%> (-1.32%)`	⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ff4a1...b0514d5. Read the comment docs.

This commit runs Airflow's test suite using pytest. fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest fixup! [AIRFLOW-6058] Running tests with pytest

ashb · 2019-12-05T10:58:58Z

tests/conftest.py

+    # Initialize kerberos
+    kerberos = os.environ.get("KRB5_KTNAME")
+    if kerberos:
+        subprocess.call(["kinit", "-kt", kerberos, "airflow"])


This should probably be check_call - if the kinit fails this won't throw an error.

Good call. @nuclearpinguin -> something as a follow up (including the setting of pytest as default test runner.

This commit runs Airflow's test suite using pytest. (cherry picked from commit e61025e)

This commit runs Airflow's test suite using pytest.

mik-laj reviewed Oct 31, 2019

View reviewed changes

tests/conftest.py Show resolved Hide resolved

feluelle reviewed Nov 1, 2019

View reviewed changes

setup.py Outdated Show resolved Hide resolved

tests/conftest.py Outdated Show resolved Hide resolved

turbaszek force-pushed the pytest-poc branch 2 times, most recently from b53a5a9 to 45b7cfd Compare November 19, 2019 16:58

turbaszek force-pushed the pytest-poc branch from 45b7cfd to af8a3ad Compare November 20, 2019 14:47

turbaszek force-pushed the pytest-poc branch 4 times, most recently from e62a969 to 6f8cc80 Compare November 25, 2019 14:59

turbaszek changed the title ~~[AIRFLOW-YYYY][POC] Running tests with pytest~~ [AIRFLOW-6058] Running tests with pytest Nov 25, 2019

turbaszek requested review from mik-laj and feluelle November 25, 2019 15:31

turbaszek force-pushed the pytest-poc branch from 6f8cc80 to 20f7cad Compare November 25, 2019 16:04

feluelle reviewed Nov 25, 2019

View reviewed changes

airflow/utils/log/colored_log.py Show resolved Hide resolved

airflow/www/views.py Outdated Show resolved Hide resolved

setup.py Outdated Show resolved Hide resolved

feluelle reviewed Nov 25, 2019

View reviewed changes

setup.py Show resolved Hide resolved

mik-laj reviewed Nov 25, 2019

View reviewed changes

airflow/www/views.py Outdated Show resolved Hide resolved

turbaszek force-pushed the pytest-poc branch 2 times, most recently from dfcaebd to fa61eeb Compare November 25, 2019 19:58

mik-laj reviewed Nov 25, 2019

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

turbaszek marked this pull request as ready for review November 25, 2019 21:21

potiuk approved these changes Nov 25, 2019

View reviewed changes

ashb reviewed Nov 25, 2019

View reviewed changes

setup.py Outdated Show resolved Hide resolved

tests/__init__.py Outdated Show resolved Hide resolved

tests/pytest.ini Outdated Show resolved Hide resolved

potiuk reviewed Nov 26, 2019

View reviewed changes

setup.py Show resolved Hide resolved

tests/pytest.ini Outdated Show resolved Hide resolved

tests/task/task_runner/test_standard_task_runner.py Outdated Show resolved Hide resolved

turbaszek force-pushed the pytest-poc branch 2 times, most recently from d939d60 to 88b7c0a Compare November 26, 2019 18:55

turbaszek force-pushed the pytest-poc branch 3 times, most recently from 9729f0f to dc84e09 Compare December 4, 2019 13:11

turbaszek force-pushed the pytest-poc branch from dc84e09 to b0514d5 Compare December 4, 2019 13:13

turbaszek requested a review from potiuk December 4, 2019 13:15

potiuk merged commit e61025e into apache:master Dec 5, 2019

ashb reviewed Dec 5, 2019

View reviewed changes

potiuk pushed a commit that referenced this pull request Dec 10, 2019

[AIRFLOW-6058] Running tests with pytest (#6472)

c387c97

This commit runs Airflow's test suite using pytest. (cherry picked from commit e61025e)

potiuk added a commit that referenced this pull request Dec 10, 2019

fixup! [AIRFLOW-6058] Running tests with pytest (#6472)

1766070

potiuk pushed a commit that referenced this pull request Dec 10, 2019

[AIRFLOW-6058] Running tests with pytest (#6472)

88450d6

This commit runs Airflow's test suite using pytest. (cherry picked from commit e61025e)

potiuk pushed a commit that referenced this pull request Dec 10, 2019

[AIRFLOW-6058] Running tests with pytest (#6472)

9aec63e

This commit runs Airflow's test suite using pytest. (cherry picked from commit e61025e)

potiuk added a commit that referenced this pull request Dec 10, 2019

fixup! [AIRFLOW-6058] Running tests with pytest (#6472)

51cca35

potiuk added a commit that referenced this pull request Dec 10, 2019

fixup! [AIRFLOW-6058] Running tests with pytest (#6472)

036165f

potiuk added a commit that referenced this pull request Dec 10, 2019

fixup! [AIRFLOW-6058] Running tests with pytest (#6472)

8287021

potiuk added a commit to potiuk/airflow that referenced this pull request Dec 10, 2019

fixup! fixup! [AIRFLOW-6058] Running tests with pytest (apache#6472)

5b4e5b2

potiuk pushed a commit that referenced this pull request Dec 10, 2019

[AIRFLOW-6058] Running tests with pytest (#6472)

973dc80

This commit runs Airflow's test suite using pytest. (cherry picked from commit e61025e)

potiuk pushed a commit that referenced this pull request Dec 11, 2019

[AIRFLOW-6058] Running tests with pytest (#6472)

bf31dd1

This commit runs Airflow's test suite using pytest. (cherry picked from commit e61025e)

potiuk added a commit that referenced this pull request Dec 11, 2019

fixup! [AIRFLOW-6058] Running tests with pytest (#6472)

09d89b7

potiuk pushed a commit that referenced this pull request Dec 11, 2019

[AIRFLOW-6058] Running tests with pytest (#6472)

542475c

This commit runs Airflow's test suite using pytest. (cherry picked from commit e61025e)

kaxil pushed a commit that referenced this pull request Dec 12, 2019

[AIRFLOW-6058] Running tests with pytest (#6472)

120c77b

This commit runs Airflow's test suite using pytest. (cherry picked from commit e61025e)

kaxil pushed a commit that referenced this pull request Dec 17, 2019

[AIRFLOW-6058] Running tests with pytest (#6472)

7ef245f

This commit runs Airflow's test suite using pytest. (cherry picked from commit e61025e)

galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020

[AIRFLOW-6058] Running tests with pytest (apache#6472)

49baced

This commit runs Airflow's test suite using pytest.

turbaszek deleted the pytest-poc branch March 14, 2020 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AIRFLOW-6058] Running tests with pytest #6472

[AIRFLOW-6058] Running tests with pytest #6472

turbaszek commented Oct 30, 2019 •

edited

Loading

feluelle commented Nov 1, 2019

feluelle commented Nov 1, 2019

akki commented Nov 20, 2019

turbaszek commented Nov 20, 2019 •

edited

Loading

potiuk left a comment

codecov-io commented Nov 26, 2019 •

edited

Loading

ashb Dec 5, 2019

potiuk Dec 5, 2019

[AIRFLOW-6058] Running tests with pytest #6472

[AIRFLOW-6058] Running tests with pytest #6472

Conversation

turbaszek commented Oct 30, 2019 • edited Loading

Jira

Description

Tests

Commits

Documentation

feluelle commented Nov 1, 2019

feluelle commented Nov 1, 2019

akki commented Nov 20, 2019

turbaszek commented Nov 20, 2019 • edited Loading

potiuk left a comment

Choose a reason for hiding this comment

codecov-io commented Nov 26, 2019 • edited Loading

Codecov Report

ashb Dec 5, 2019

Choose a reason for hiding this comment

potiuk Dec 5, 2019

Choose a reason for hiding this comment

turbaszek commented Oct 30, 2019 •

edited

Loading

turbaszek commented Nov 20, 2019 •

edited

Loading

codecov-io commented Nov 26, 2019 •

edited

Loading