Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5875] Fix typo in example_qubole_operator.py #6525

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 8, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk requested a review from mik-laj November 8, 2019 13:44
@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #6525 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6525      +/-   ##
==========================================
- Coverage   83.98%   83.74%   -0.24%     
==========================================
  Files         635      635              
  Lines       36720    36750      +30     
==========================================
- Hits        30838    30776      -62     
- Misses       5882     5974      +92
Impacted Files Coverage Δ
...ow/contrib/example_dags/example_qubole_operator.py 80% <ø> (+47.5%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/models/taskinstance.py 93.28% <0%> (-0.51%) ⬇️
airflow/utils/dag_processing.py 58.31% <0%> (-0.17%) ⬇️
airflow/gcp/operators/dataflow.py 99.07% <0%> (ø) ⬆️
airflow/gcp/hooks/dataflow.py 92.24% <0%> (+1.08%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f229f94...445fa54. Read the comment docs.

@potiuk potiuk merged commit 33ddcd9 into apache:master Nov 8, 2019
potiuk added a commit that referenced this pull request Nov 8, 2019
potiuk added a commit that referenced this pull request Nov 12, 2019
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
kaxil pushed a commit that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants