Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIRFLOW-2143a - Fix TaskTries graph counts off-by-1 #6526

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

mcw0933
Copy link
Contributor

@mcw0933 mcw0933 commented Nov 8, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mcw0933
Copy link
Contributor Author

mcw0933 commented Nov 8, 2019

This PR is the same work as in #5297, but based off the v1-10-test branch as requested by @kaxil

@kaxil
Copy link
Member

kaxil commented Nov 8, 2019

Thanks @mcw0933 - Can we change this for airflow/www_rbac folder too, please? thanks

@mcw0933
Copy link
Contributor Author

mcw0933 commented Nov 8, 2019

Ok - changes are made to both views.py

@codecov-io
Copy link

Codecov Report

Merging #6526 into v1-10-test will increase coverage by <.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v1-10-test    #6526      +/-   ##
==============================================
+ Coverage       79.63%   79.63%   +<.01%     
==============================================
  Files             518      518              
  Lines           35269    35267       -2     
==============================================
  Hits            28086    28086              
+ Misses           7183     7181       -2
Impacted Files Coverage Δ
airflow/www/views.py 45.03% <0%> (+0.05%) ⬆️
airflow/models/taskinstance.py 93.67% <100%> (+0.02%) ⬆️
airflow/www_rbac/views.py 75.61% <50%> (+0.1%) ⬆️
airflow/jobs/local_task_job.py 85.71% <0%> (-4.77%) ⬇️
airflow/utils/dag_processing.py 59.02% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713323d...66394c0. Read the comment docs.

@kaxil kaxil merged commit 1bd1f8f into apache:v1-10-test Nov 20, 2019
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants