Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5883] Don't use .count() from sqlalchemy to count #6532

Merged

Conversation

saguziel
Copy link
Contributor

@saguziel saguziel commented Nov 8, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5883
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@saguziel saguziel force-pushed the aguziel-2019-11-airflow-optimize-counts branch from 51b7625 to 13edf54 Compare November 8, 2019 22:27
@saguziel saguziel changed the title [Airflow-5883] Don't use .count() from sqlalchemy to count [AIRFLOW-5883] Don't use .count() from sqlalchemy to count Nov 8, 2019
Copy link
Member

@KevinYang21 KevinYang21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change.

@saguziel saguziel force-pushed the aguziel-2019-11-airflow-optimize-counts branch from 13edf54 to 022553c Compare November 9, 2019 00:39
@saguziel saguziel force-pushed the aguziel-2019-11-airflow-optimize-counts branch from 022553c to 2a734d5 Compare November 9, 2019 02:07
@codecov-io
Copy link

codecov-io commented Nov 9, 2019

Codecov Report

Merging #6532 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6532     +/-   ##
=========================================
- Coverage   84.08%   83.78%   -0.3%     
=========================================
  Files         635      635             
  Lines       36849    36850      +1     
=========================================
- Hits        30983    30875    -108     
- Misses       5866     5975    +109
Impacted Files Coverage Δ
airflow/sensors/external_task_sensor.py 85.96% <100%> (+0.25%) ⬆️
airflow/models/dag.py 90.87% <100%> (ø) ⬆️
airflow/models/taskinstance.py 93.79% <100%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/utils/dag_processing.py 58.48% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813cd43...2a734d5. Read the comment docs.

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @saguziel

@feluelle feluelle merged commit 084d5f8 into apache:master Nov 10, 2019
kaxil pushed a commit that referenced this pull request Dec 17, 2019
ashb pushed a commit that referenced this pull request Dec 17, 2019
ashb pushed a commit that referenced this pull request Dec 19, 2019
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants