-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5850] Capture task logs in DockerSwarmOperator #6552
Conversation
@akki Please fix flake8 violations:
|
382ae5c
to
ee4daac
Compare
Codecov Report
@@ Coverage Diff @@
## master #6552 +/- ##
==========================================
+ Coverage 84.32% 85.25% +0.93%
==========================================
Files 676 756 +80
Lines 38363 39884 +1521
==========================================
+ Hits 32348 34003 +1655
+ Misses 6015 5881 -134
Continue to review full report at Codecov.
|
Getting another set of eyes always helps. Thanks @hredestig and @OmerJog for reviewing, really appreciate. I've fixed the concerns mentioned and CI also seems to be green now. :) |
@potiuk I am guessing you'd be the correct admin to ping for this PR - may I request your review on this? |
Hi This would make debugging |
9d29353
to
5bc1616
Compare
Hi Airflow team Would anyone please help review and approve this PR? (PS - the postgres connection error in CI don't seem related to this PR) |
Sorry, I am on vacation for a couple of weeks. Will start working on this once I come back. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@akki Is this change complete? Travis is green, but I do not see discussion. The PR author is responsible for engaging people so that this change can come in.
More info: |
Hi @mik-laj I had made these 2 comments when I fixed everything & completed it last time: Do I need to mark it as "done" somewhere else as well or do something else? Can you please tell me what else I need to do to move this PR forward and get further reviews from Airflow authors? |
Sorry, now I understand the 2nd part of ur comment. Do you mean I need to join Slack and then ping |
Notifications on Github are not always effective because contributors often have notifications from many repositories configured and it's easy to miss a message in the stream. In practice, writing on #how-to-pr or private messages seems to be much more effective. Contributors can configure the "Remind me" option so they don't forget to write back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @dimberman Can you look again because you gave a red stamp on this PR?
Cool, thanks for explaining. :) I'll keep that in mind in future. |
One more information. If you have other questions, please visit the #newbie-questions Slack channel where you can ask any questions you want - it's a safe space where it is expected that people asking questions do not know a lot about Airflow (yet!). If you started worrying and didn't know what to do to get yours merged then you could ask in this channel. |
|
Make sure you have checked all steps below.
Jira
Description
Tests
test_logging
Commits
Documentation